piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity
143a13622f
dolphin/Source/CMakeLists.txt

83 lines
3.0 KiB
CMake
Raw Normal View History

CMake: add DOLPHIN_CXX_FLAGS option Lets you do fun stuff like turning off warnings globally, then re-enabling all warnings + extra warnings + warnings as errors for Dolphin only.
2017-10-23 11:59:54 -06:00
option(DOLPHIN_CXX_FLAGS "Flags used to compile Dolphin-only sources" "")
if(DOLPHIN_CXX_FLAGS)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DOLPHIN_CXX_FLAGS}")
endif()
CMake: Move Windows defines to Source/CMakeLists.txt Messes up various Externals, like PortAudio.
2017-01-27 01:58:21 -07:00
if(CMAKE_SYSTEM_NAME MATCHES "Windows")
add_definitions(-DNOMINMAX)
add_definitions(-DUNICODE)
add_definitions(-D_UNICODE)
add_definitions(-DWIN32_LEAN_AND_MEAN)
CMake: use _SCL_SECURE_NO_WARNINGS instead of _SECURE_SCL=0 _SECURE_SCL is deprecated (and doesn't seem to disable warnings anymore with Visual Studio 2015).
2017-02-10 17:28:37 -07:00
add_definitions(-D_SCL_SECURE_NO_WARNINGS)
CMake: Move Windows defines to Source/CMakeLists.txt Messes up various Externals, like PortAudio.
2017-01-27 01:58:21 -07:00
add_definitions(-D_CRT_SECURE_NO_WARNINGS)
add_definitions(-D_CRT_SECURE_NO_DEPRECATE)
Core/CMake: Silence some warnings
2019-05-08 16:18:14 -06:00
add_definitions(-D_CRT_NONSTDC_NO_WARNINGS)
CMake: Add -D_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING The CMake Windows build was broken because of me adding a usage of std::codecvt_utf8_utf16 to StringUtil.cpp. Kinda silly to have a warning for an API with no standard replacement available...
2020-07-30 12:21:51 -06:00
add_definitions(-D_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING)
CMake: Move Windows defines to Source/CMakeLists.txt Messes up various Externals, like PortAudio.
2017-01-27 01:58:21 -07:00
endif()
cmake: Use C++latest everywhere on MSVC.
2022-05-20 19:31:41 -06:00
if (NOT MSVC)
Move to C++20 for non-MSVC compilers
2022-06-11 07:39:04 -06:00
set(CMAKE_CXX_STANDARD 20)
cmake: Use C++latest everywhere on MSVC.
2022-05-20 19:31:41 -06:00
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
CMake: Build with -std:c++latest for MSVC Making CMake match MSBuild in this aspect will hopefully reduce how often we accidentally break the MSVC CMake build.
2021-03-03 15:44:35 -07:00
endif()
CMake: Enable generation of compile_commands.json. Used for intellisense in Visual Studio Code et al.
2019-10-06 06:59:23 -06:00
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
add the same flags to CMake
2017-05-26 15:01:41 -06:00
CMake: Add MSVC support
2019-05-08 15:57:47 -06:00
if (MSVC)
cmake: fix MSVC PCH support I'm not sure if the previous implementation ever worked.
2022-04-27 00:57:13 -06:00
# Compile PCH
CMake/Windows: Add PCH support
2019-05-15 11:28:04 -06:00
add_subdirectory(PCH)
Enable extra warnings in Source CMakeLists, not in root CMakeLists Having extra warnings enabled for everything including external libraries produces an overwhelming amount of warnings in code that isn't even part of our codebase. Move the various warning flags to Source/CMakeLists.txt to get rid of those useless warnings. Note that the Source CMakeLists.txt is already where the MSVC warnings are defined, so this commit improves consistency as well.
2020-11-20 16:59:17 -07:00
else()
check_and_add_flag(HAVE_WALL -Wall)
# TODO: would like these but they produce overwhelming amounts of warnings
#check_and_add_flag(EXTRA -Wextra)
#check_and_add_flag(MISSING_FIELD_INITIALIZERS -Wmissing-field-initializers)
#check_and_add_flag(SWITCH_DEFAULT -Wswitch-default)
#check_and_add_flag(FLOAT_EQUAL -Wfloat-equal)
#check_and_add_flag(CONVERSION -Wconversion)
#check_and_add_flag(ZERO_AS_NULL_POINTER_CONSTANT -Wzero-as-null-pointer-constant)
check_and_add_flag(TYPE_LIMITS -Wtype-limits)
check_and_add_flag(SIGN_COMPARE -Wsign-compare)
check_and_add_flag(IGNORED_QUALIFIERS -Wignored-qualifiers)
check_and_add_flag(UNINITIALIZED -Wuninitialized)
check_and_add_flag(LOGICAL_OP -Wlogical-op)
check_and_add_flag(SHADOW -Wshadow)
check_and_add_flag(INIT_SELF -Winit-self)
check_and_add_flag(MISSING_DECLARATIONS -Wmissing-declarations)
check_and_add_flag(MISSING_VARIABLE_DECLARATIONS -Wmissing-variable-declarations)
Disable -Wstringop-truncation warnings Disable -Wstringop-truncation warnings as they result in many false positives. In most (all?) cases where std::strncpy is used, we want to fill the entire buffer or match emulated code that also ignores the null terminator, so the warnings are not useful. Given that Dolphin itself mostly uses std::string, they do not really help catch any bugs.
2020-11-20 17:44:15 -07:00
# Disable -Wstringop-truncation warnings as they result in many false positives.
# In most (all?) cases where std::strncpy is used, we want to fill the entire buffer
# or match emulated code that also ignores the null terminator, so the warnings are not useful.
# Given that Dolphin itself mostly uses std::string, they do not really help catch any bugs.
check_cxx_compiler_flag(-Wstringop-truncation HAS_STRINGOP_TRUNCATION_WARNING)
if (HAS_STRINGOP_TRUNCATION_WARNING)
check_and_add_flag(NO_STRINGOP_TRUNCATION -Wno-stringop-truncation)
endif()
Turn format string issues into compile-time errors If the compiler can detect an issue with a format string at compile time, then we should take advantage of that and turn the issue into a hard compile-time error as such problems almost always lead to UB. This helps with catching logging or assertion messages that have been converted over to fmt but are still using the old, non-fmt variants of the logging macros. This commit also fixes all incorrect usages that I could find.
2020-11-25 10:59:47 -07:00
# Format string issues that the compiler can detect should be compile time errors.
check_cxx_compiler_flag(-Wformat HAS_FORMAT_WARNING)
if (HAS_FORMAT_WARNING)
check_and_add_flag(FORMAT_WARNING_TO_ERROR -Werror=format)
endif()
CMake: Add MSVC support
2019-05-08 15:57:47 -06:00
endif()
cmake: Move C++ standard requirement out of global scope to Source/
2017-01-20 09:44:23 -07:00
# These aren't actually needed for C11/C++11
# but some dependencies require them (LLVM, libav).
add_definitions(-D__STDC_LIMIT_MACROS)
add_definitions(-D__STDC_CONSTANT_MACROS)
Add an experimental CMake build system as a possible replacement for SCons. Only tested on Linux, should work on OS X and Windows in the future as well though. Some notes about this: - config.h doesn't get written yet, so you'll have to use one generated by SCons - dependency checking isn't really implemented, yet. Just some basic checks for OpenGL or ALSA, we need something more sophisticated though. - the OpenGL plugin fails to load for some reason which I can't debug right now due to the libc debuginfo package version in openSUSE not matching the runtime packages - there's even some support for generating install packages (rpm/deb/.. packages, NSIS installer, etc). It doesn't work properly right now though, since some paths seem to be hardcoded into Dolphin's source - probably lots of other stuff I forgot... Just take a look at all the TODOs in the CMakeLists.txt files for more information ;P Additionally, I added various files to the svn:ignore list. tl;dr: Unless you are a dev or you're building binary packages, this commit shouldn't bother you :P git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@6326 8ced0084-cf51-0410-be5f-012b33b47a6e
2010-11-01 09:47:02 -06:00
add_subdirectory(Core)
Strip the Android shared library file. This cuts down the shared library size from ~11MB to ~5.5MB
2016-01-20 09:32:53 -07:00
if (ANDROID)
CMakeLists: Normalize whitespace Normalizes tabs to spaces to follow our codebase's indentation style.
2017-03-01 05:43:43 -07:00
add_subdirectory(Android/jni)
Strip the Android shared library file. This cuts down the shared library size from ~11MB to ~5.5MB
2016-01-20 09:32:53 -07:00
endif()
cmake: Conditionally build the unit tests. This allows to skip building the unit tests and avoids the dependency on gtest when doing so.
2018-12-08 15:06:23 -07:00
if (ENABLE_TESTS)
add_subdirectory(UnitTests)
endif()
Add the DSPTool and UnitTests to the cmake build. They are optional, and to enable them add -DDSTPTOOL and -DUNITTESTS to the cmake command line. Also, don't check to see if a directory is a wad file. They aren't. This removes an annoying and invalid debug assertion with the debug build. git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7682 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-17 19:47:55 -06:00
if (DSPTOOL)
CMakeLists: Normalize whitespace Normalizes tabs to spaces to follow our codebase's indentation style.
2017-03-01 05:43:43 -07:00
add_subdirectory(DSPTool)
Add the DSPTool and UnitTests to the cmake build. They are optional, and to enable them add -DDSTPTOOL and -DUNITTESTS to the cmake command line. Also, don't check to see if a directory is a wad file. They aren't. This removes an annoying and invalid debug assertion with the debug build. git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7682 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-17 19:47:55 -06:00
endif()
Fix various comment typos
2016-09-11 16:25:45 -06:00
# TODO: Add DSPSpy. Preferably make it option() and cpack component
Reference in New Issue Copy Permalink