dolphin/Source/Core/DolphinQt/Config/Graphics/GraphicsChoice.h

// Copyright 2017 Dolphin Emulator Project
// Licensed under GPLv2+
// Refer to the license.txt file included.

#pragma once

#include <QComboBox>

#include "Common/Config/Config.h"

class GraphicsChoice : public QComboBox
{
  Q_OBJECT
public:
  GraphicsChoice(const QStringList& options, const Config::ConfigInfo<int>& setting);

private:
  void Update(int choice);

  Config::ConfigInfo<int> m_setting;
};
Qt: Implement graphics window and controls 2017-06-15 17:42:12 -06:00			`// Copyright 2017 Dolphin Emulator Project`
			`// Licensed under GPLv2+`
			`// Refer to the license.txt file included.`

			`#pragma once`

			`#include <QComboBox>`

Config: Add support for enums This makes it possible to use enums as the config type. Default values are now clearer and there's no need for casts when calling Config::Get/Set anymore. In order to add support for enums, the common code was updated to handle enums by using the underlying type when loading/saving settings. A copy constructor is also provided for conversions from `ConfigInfo<Enum>` to `ConfigInfo<underlying_type<Enum>>` so that enum settings can still easily work with code that doesn't care about the actual enum values (like Graphics{Choice,Radio} in DolphinQt2 which only treat the setting as an integer). 2018-05-11 14:38:44 -06:00			`#include "Common/Config/Config.h"`
Qt: Implement graphics window and controls 2017-06-15 17:42:12 -06:00
			`class GraphicsChoice : public QComboBox`
			`{`
DolphinQt2: Add missing Q_OBJECT macro to all QObject-related classes missing it Without this macro, if any signals or slots were attempted to be used, they wouldn't work; neither would various other features of the Qt meta-object system. This can also lead to weird behavior in other circumstances. Qt's documentation specifically states: "Therefore, we strongly recommend that all subclasses of QObject use the Q_OBJECT macro regardless of whether or not they actually use signals, slots, and properties." on its page for "The Meta-Object System", which can be seen here: https://doc.qt.io/qt-5/metaobjects.html Let's opt for "always do the right thing", and keep the code extensible for the future and not have random things blow up on us. 2018-05-13 14:16:20 -06:00			`Q_OBJECT`
Qt: Implement graphics window and controls 2017-06-15 17:42:12 -06:00			`public:`
			`GraphicsChoice(const QStringList& options, const Config::ConfigInfo<int>& setting);`

			`private:`
			`void Update(int choice);`

Config: Add support for enums This makes it possible to use enums as the config type. Default values are now clearer and there's no need for casts when calling Config::Get/Set anymore. In order to add support for enums, the common code was updated to handle enums by using the underlying type when loading/saving settings. A copy constructor is also provided for conversions from `ConfigInfo<Enum>` to `ConfigInfo<underlying_type<Enum>>` so that enum settings can still easily work with code that doesn't care about the actual enum values (like Graphics{Choice,Radio} in DolphinQt2 which only treat the setting as an integer). 2018-05-11 14:38:44 -06:00			`Config::ConfigInfo<int> m_setting;`
Qt: Implement graphics window and controls 2017-06-15 17:42:12 -06:00			`};`