piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

VolumeDirectory: Don't use references inappropriately

Browse Source 
Integers should be passed as pointers when a function
modifies them (to make it clear that they get modified).
This commit is contained in:
JosJuice
2016-12-26 09:52:18 +01:00
parent 9c8e27e3bb
commit 00aa2d37e9
2 changed files with 55 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Source/Core/DiscIO/VolumeDirectory.h
View File

@ -75,18 +75,18 @@ private:
void SetDOL(const std::string& _rDOL);
// writing to read buffer
void WriteToBuffer(u64 _SrcStartAddress, u64 _SrcLength, const u8* _Src, u64& _Address,
u64& _Length, u8*& _pBuffer) const;
void WriteToBuffer(u64 _SrcStartAddress, u64 _SrcLength, const u8* _Src, u64* _Address,
u64* _Length, u8** _pBuffer) const;
void PadToAddress(u64 _StartAddress, u64& _Address, u64& _Length, u8*& _pBuffer) const;
void PadToAddress(u64 _StartAddress, u64* _Address, u64* _Length, u8** _pBuffer) const;
void Write32(u32 data, u32 offset, std::vector<u8>* const buffer);
// FST creation
void WriteEntryData(u32& entryOffset, u8 type, u32 nameOffset, u64 dataOffset, u64 length);
void WriteEntryName(u32& nameOffset, const std::string& name);
void WriteDirectory(const File::FSTEntry& parent_entry, u32& fstOffset, u32& nameOffset,
u64& dataOffset, u32 parentEntryNum);
void WriteEntryData(u32* entryOffset, u8 type, u32 nameOffset, u64 dataOffset, u64 length);
void WriteEntryName(u32* nameOffset, const std::string& name);
void WriteDirectory(const File::FSTEntry& parent_entry, u32* fstOffset, u32* nameOffset,
u64* dataOffset, u32 parentEntryNum);
std::string m_rootDirectory;