piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 14:49:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

DSP: Make Mailbox enum strongly typed

Browse Source 
Avoids implicit conversions and also prevents dumping identifiers into
the current namespace.
This commit is contained in:
Lioncash
2020-12-29 12:18:42 -05:00
parent ee048ad83c
commit 024e983c3a
3 changed files with 32 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/Core/HW/DSPLLE/DSPLLE.cpp
View File

@ -213,25 +213,25 @@ u16 DSPLLE::DSP_ReadControlRegister()
u16 DSPLLE::DSP_ReadMailBoxHigh(bool cpu_mailbox)
{
return m_dsp_core.ReadMailboxHigh(cpu_mailbox ? MAILBOX_CPU : MAILBOX_DSP);
return m_dsp_core.ReadMailboxHigh(cpu_mailbox ? Mailbox::CPU : Mailbox::DSP);
}
u16 DSPLLE::DSP_ReadMailBoxLow(bool cpu_mailbox)
{
return m_dsp_core.ReadMailboxLow(cpu_mailbox ? MAILBOX_CPU : MAILBOX_DSP);
return m_dsp_core.ReadMailboxLow(cpu_mailbox ? Mailbox::CPU : Mailbox::DSP);
}
void DSPLLE::DSP_WriteMailBoxHigh(bool cpu_mailbox, u16 value)
{
if (cpu_mailbox)
{
if ((m_dsp_core.PeekMailbox(MAILBOX_CPU) & 0x80000000) != 0)
if ((m_dsp_core.PeekMailbox(Mailbox::CPU) & 0x80000000) != 0)
{
// the DSP didn't read the previous value
WARN_LOG_FMT(DSPLLE, "Mailbox isn't empty ... strange");
}
m_dsp_core.WriteMailboxHigh(MAILBOX_CPU, value);
m_dsp_core.WriteMailboxHigh(Mailbox::CPU, value);
}
else
{
@ -243,7 +243,7 @@ void DSPLLE::DSP_WriteMailBoxLow(bool cpu_mailbox, u16 value)
{
if (cpu_mailbox)
{
m_dsp_core.WriteMailboxLow(MAILBOX_CPU, value);
m_dsp_core.WriteMailboxLow(Mailbox::CPU, value);
}
else
{