mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-07-23 06:09:50 -06:00
GameFile: handle missing banners in UI instead
Currently, GameFile returns a generic banner if the file didn't have one available (either because the file format doesn't support it, or because it's a Wii file without an associated save). It makes more sense to handle the lack of banner in the UI layer. The game list will use the generic missing banner explicitly (no change from before), and the game info window now omits the banner display entirely if the file didn't have one (since it's not useful to display/allow the user to save the "missing banner" banner).
This commit is contained in:
@ -69,7 +69,6 @@ QGroupBox* InfoWidget::CreateBannerDetails()
|
||||
m_long_maker = CreateValueDisplay();
|
||||
m_description = new QTextEdit();
|
||||
m_description->setReadOnly(true);
|
||||
QWidget* banner = CreateBannerGraphic();
|
||||
CreateLanguageSelector();
|
||||
|
||||
layout->addRow(tr("Show Language:"), m_language_selector);
|
||||
@ -85,7 +84,11 @@ QGroupBox* InfoWidget::CreateBannerDetails()
|
||||
{
|
||||
layout->addRow(tr("Name:"), m_long_name);
|
||||
}
|
||||
layout->addRow(tr("Banner:"), banner);
|
||||
|
||||
if (!m_game.GetBanner().isNull())
|
||||
{
|
||||
layout->addRow(tr("Banner:"), CreateBannerGraphic());
|
||||
}
|
||||
|
||||
group->setLayout(layout);
|
||||
return group;
|
||||
|
Reference in New Issue
Block a user