piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-25 07:09:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix a memory leak in ExpressionParser.cpp"

Browse Source 
This reverts commit cce809ac90.

The code was actually correct: "expr" is never allocated when an error is
returned. This means when the expression parser fails, deleting "expr" means
deleting an uninitialized pointer.
This commit is contained in:
Pierre Bourdon
2013-08-09 10:46:11 +02:00
parent 90d454d22f
commit 0aa9308006
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/InputCommon/Src/ControllerInterface/ExpressionParser.cpp
View File

@ -549,10 +549,7 @@ ExpressionParseStatus ParseExpressionInner(std::string str, ControlFinder &finde
Parser p(tokens, finder); Parser p(tokens, finder);
status = p.Parse(&expr); status = p.Parse(&expr);
if (status != EXPRESSION_PARSE_SUCCESS) if (status != EXPRESSION_PARSE_SUCCESS)
{
delete expr;
return status; return status;
}
*expr_out = expr; *expr_out = expr;
return EXPRESSION_PARSE_SUCCESS; return EXPRESSION_PARSE_SUCCESS;