piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 06:39:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

DiscIO/VolumeVerifier: Take std::string by value in AddProblem()

Browse Source 
This allows both std::moving into the function and moving the parameter
from within the function, potentially avoiding an unnecessary copy.
This commit is contained in:
Lioncash
2019-05-27 10:12:20 -04:00
parent a1f77fd14b
commit 0ccaa2b5d6
2 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/DiscIO/VolumeVerifier.h
View File

@ -90,7 +90,7 @@ private:
void CheckPartitions();
bool CheckPartition(const Partition& partition); // Returns false if partition should be ignored
std::string GetPartitionName(std::optional<u32> type) const;
void CheckCorrectlySigned(const Partition& partition, const std::string& error_text);
void CheckCorrectlySigned(const Partition& partition, std::string error_text);
bool IsDebugSigned() const;
bool ShouldHaveChannelPartition() const;
bool ShouldHaveInstallPartition() const;
@ -103,7 +103,7 @@ private:
void SetUpHashing();
bool CheckContentIntegrity(const IOS::ES::Content& content);
void AddProblem(Severity severity, const std::string& text);
void AddProblem(Severity severity, std::string text);
const Volume& m_volume;
Result m_result;