piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-23 06:09:50 -06:00
Code Issues Packages Projects Releases Wiki Activity

SysConf: const-correctness

Browse Source
This commit is contained in:
Lioncash
2017-03-04 19:09:44 -05:00
parent 1ebd2cd7c3
commit 0e5a367ca3
3 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
Source/Core/Common/SysConf.h
View File

@ -53,13 +53,13 @@ struct SSysConfEntry
std::vector<u8> data;
template <class T>
T GetData()
T GetData() const
{
T extracted_data;
std::memcpy(&extracted_data, data.data(), sizeof(T));
return extracted_data;
}
bool GetArrayData(u8* dest, u16 destSize)
bool GetArrayData(u8* dest, u16 destSize) const
{
if (dest && destSize >= dataLength)
{
@ -68,7 +68,7 @@ struct SSysConfEntry
}
return false;
}
bool SetArrayData(u8* buffer, u16 bufferSize)
bool SetArrayData(const u8* buffer, u16 bufferSize)
{
if (buffer)
{
@ -85,9 +85,9 @@ public:
SysConf(Common::FromWhichRoot root_type);
~SysConf();
bool IsValid() { return m_IsValid; }
bool IsValid() const { return m_IsValid; }
template <class T>
T GetData(const char* sectionName)
T GetData(const char* sectionName) const
{
if (!m_IsValid)
{
@ -95,13 +95,13 @@ public:
return 0;
}
std::vector<SSysConfEntry>::iterator index = m_Entries.begin();
for (; index < m_Entries.end() - 1; ++index)
auto index = m_Entries.cbegin();
for (; index < m_Entries.cend() - 1; ++index)
{
if (strcmp(index->name, sectionName) == 0)
break;
}
if (index == m_Entries.end() - 1)
if (index == m_Entries.cend() - 1)
{
PanicAlertT("Section %s not found in SYSCONF", sectionName);
return 0;
@ -110,35 +110,35 @@ public:
return index->GetData<T>();
}
bool GetArrayData(const char* sectionName, u8* dest, u16 destSize)
bool GetArrayData(const char* sectionName, u8* dest, u16 destSize) const
{
if (!m_IsValid)
{
PanicAlertT("Trying to read from invalid SYSCONF");
return 0;
return false;
}
std::vector<SSysConfEntry>::iterator index = m_Entries.begin();
for (; index < m_Entries.end() - 1; ++index)
auto index = m_Entries.cbegin();
for (; index < m_Entries.cend() - 1; ++index)
{
if (strcmp(index->name, sectionName) == 0)
break;
}
if (index == m_Entries.end() - 1)
if (index == m_Entries.cend() - 1)
{
PanicAlertT("Section %s not found in SYSCONF", sectionName);
return 0;
return false;
}
return index->GetArrayData(dest, destSize);
}
bool SetArrayData(const char* sectionName, u8* buffer, u16 bufferSize)
bool SetArrayData(const char* sectionName, const u8* buffer, u16 bufferSize)
{
if (!m_IsValid)
return false;
std::vector<SSysConfEntry>::iterator index = m_Entries.begin();
auto index = m_Entries.begin();
for (; index < m_Entries.end() - 1; ++index)
{
if (strcmp(index->name, sectionName) == 0)
@ -159,7 +159,7 @@ public:
if (!m_IsValid)
return false;
std::vector<SSysConfEntry>::iterator index = m_Entries.begin();
auto index = m_Entries.begin();
for (; index < m_Entries.end() - 1; ++index)
{
if (strcmp(index->name, sectionName) == 0)