piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

Completely fixed DSPTool, on all of its memory leaks, bad API and bad C++. (compiling with include works perfectly)

Browse Source 
More small leftover fixes

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@3071 8ced0084-cf51-0410-be5f-012b33b47a6e
This commit is contained in:
XTra.KrazzY
2009-04-25 10:38:26 +00:00
parent 72febe7b8a
commit 1045fc7e98
14 changed files with 153 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Source/Core/DSPCore/Src/disassemble.cpp
View File

@ -72,7 +72,7 @@ DSPDisassembler::~DSPDisassembler()
fclose(uo);
}
bool DSPDisassembler::Disassemble(int start_pc, const std::vector<u16> &code, std::string *text)
bool DSPDisassembler::Disassemble(int start_pc, const std::vector<u16> &code, std::string &text)
{
const char *tmp1 = "tmp1.bin";
const char *tmp2 = "tmp.txt";
@ -187,7 +187,7 @@ static void MakeLowerCase(char *ptr)
}
}
void DSPDisassembler::DisOpcode(const u16 *binbuf, int pass, u16 *pc, std::string *dest)
void DSPDisassembler::DisOpcode(const u16 *binbuf, int pass, u16 *pc, std::string &dest)
{
char buffer[256];
char *buf = buffer;
@ -200,7 +200,7 @@ void DSPDisassembler::DisOpcode(const u16 *binbuf, int pass, u16 *pc, std::strin
if ((*pc & 0x7fff) >= 0x1000)
{
*pc++;
dest->append("; outside memory");
dest.append("; outside memory");
return;
}
@ -318,10 +318,10 @@ void DSPDisassembler::DisOpcode(const u16 *binbuf, int pass, u16 *pc, std::strin
*pc += opc->size & ~P_EXT;
if (pass == 2)
dest->append(buffer);
dest.append(buffer);
}
bool DSPDisassembler::DisFile(const char* name, int pass, std::string *output)
bool DSPDisassembler::DisFile(const char* name, int pass, std::string &output)
{
FILE* in = fopen(name, "rb");
if (in == NULL)
@ -342,7 +342,7 @@ bool DSPDisassembler::DisFile(const char* name, int pass, std::string *output)
{
DisOpcode(binbuf, pass, &pc, output);
if (pass == 2)
output->append("\n");
output.append("\n");
}
delete [] binbuf;
return true;