From 1065dc44384675f35df1b3a62f0173c4f9cc0d5a Mon Sep 17 00:00:00 2001
From: Shawn Hoffman <godisgovernment@gmail.com>
Date: Wed, 7 Jun 2017 04:43:08 -0700
Subject: [PATCH] msbuild: set warning level 4

---
 Source/VSProps/Base.props | 27 +++++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/Source/VSProps/Base.props b/Source/VSProps/Base.props
index 4fe3f0e379..77732dc364 100644
--- a/Source/VSProps/Base.props
+++ b/Source/VSProps/Base.props
@@ -76,7 +76,7 @@
       higher declaration can be contained to just the XAudio2/XInput related code.
       -->
       <PreprocessorDefinitions>_WIN32_WINNT=0x0602;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-      <WarningLevel>Level3</WarningLevel>
+      <WarningLevel>Level4</WarningLevel>
       <TreatWarningAsError>true</TreatWarningAsError>
       <IntrinsicFunctions>true</IntrinsicFunctions>
       <RuntimeTypeInfo>false</RuntimeTypeInfo>
@@ -95,13 +95,28 @@
       <DebugInformationFormat>OldStyle</DebugInformationFormat>
       <DiagnosticsFormat>Caret</DiagnosticsFormat>
       <!--
-      4996 is for GetVersionEx being marked as depreciated - which is idiotic and there's
-        not much else we can do since many externals use it. The bad part is that there doesn't
-        seem to be a way to only ignore the specific instance we don't care about...
-      4351 squashes a warning telling us the compiler is behaving as expected (instead of old,
-        broken behavior).
+      4996  is for GetVersionEx being marked as deprecated - which is idiotic and there's not much
+                else we can do since many externals use it. The bad part is that there doesn't
+                seem to be a way to only ignore the specific instance we don't care about...
+      4351  new behavior: elements of array 'array' will be default initialized
       -->
       <DisableSpecificWarnings>4996;4351</DisableSpecificWarnings>
+      <!-- Warnings one may want to ignore when using Level4.
+      4201  nonstandard extension used : nameless struct/union
+      4127  conditional expression is constant
+      4100  'identifier' : unreferenced formal parameter
+      4244  'conversion' conversion from 'type1' to 'type2', possible loss of data
+                Level4 warns if type1==int and there is narrowing
+      4121  'symbol' : alignment of a member was sensitive to packing
+      4324  Padding was added at the end of a structure because you specified a __declspec(align) value.
+      4714  function 'function' marked as __forceinline not inlined
+      -->
+      <DisableSpecificWarnings>4201;4127;4100;4244;4121;4324;4714;%(DisableSpecificWarnings)</DisableSpecificWarnings>
+      <!-- Level4 warnings which should eventually be enabled
+      4245  'conversion' : conversion from 'type1' to 'type2', signed/unsigned mismatch
+                Currently jits use some annoying code patterns which makes this common
+      -->
+      <DisableSpecificWarnings>4245;%(DisableSpecificWarnings)</DisableSpecificWarnings>
     </ClCompile>
     <!--ClCompile Debug-->
     <ClCompile Condition="'$(Configuration)'=='Debug'">