From 10fea99d8049d3224f736bcfaa1cf981fa0d14ec Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Fri, 22 Nov 2019 14:51:57 -0500
Subject: [PATCH] InputCommon/FunctionExpression: Make MakeFunctionExpression()
 take a std::string_view

There's nothing within this function that requires a copy of the string
to be made, so we can make use of a non-owning view
---
 .../Core/InputCommon/ControlReference/FunctionExpression.cpp   | 2 +-
 Source/Core/InputCommon/ControlReference/FunctionExpression.h  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Source/Core/InputCommon/ControlReference/FunctionExpression.cpp b/Source/Core/InputCommon/ControlReference/FunctionExpression.cpp
index ae3f14097e..abc6eece02 100644
--- a/Source/Core/InputCommon/ControlReference/FunctionExpression.cpp
+++ b/Source/Core/InputCommon/ControlReference/FunctionExpression.cpp
@@ -447,7 +447,7 @@ private:
   mutable Clock::time_point m_release_time = Clock::now();
 };
 
-std::unique_ptr<FunctionExpression> MakeFunctionExpression(std::string name)
+std::unique_ptr<FunctionExpression> MakeFunctionExpression(std::string_view name)
 {
   if ("not" == name)
     return std::make_unique<NotExpression>();
diff --git a/Source/Core/InputCommon/ControlReference/FunctionExpression.h b/Source/Core/InputCommon/ControlReference/FunctionExpression.h
index 44d9092ce9..e247d9a623 100644
--- a/Source/Core/InputCommon/ControlReference/FunctionExpression.h
+++ b/Source/Core/InputCommon/ControlReference/FunctionExpression.h
@@ -6,6 +6,7 @@
 
 #include <memory>
 #include <string>
+#include <string_view>
 #include <variant>
 #include <vector>
 
@@ -47,6 +48,6 @@ private:
   std::vector<std::unique_ptr<Expression>> m_args;
 };
 
-std::unique_ptr<FunctionExpression> MakeFunctionExpression(std::string name);
+std::unique_ptr<FunctionExpression> MakeFunctionExpression(std::string_view name);
 
 }  // namespace ciface::ExpressionParser