piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-28 01:49:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

Settings: Bugfix. Remove Aspect Ratio combobox signal so it doesn't trigger a settings changed save.

Browse Source
This commit is contained in:
TryTwo
2025-05-02 15:32:37 -07:00
parent 63572f15fc
commit 1aabae49ed
2 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Source/Core/DolphinQt/Config/Graphics/GeneralWidget.cpp
View File

@ -79,6 +79,8 @@ void GeneralWidget::CreateWidgets()
Config::GFX_CUSTOM_ASPECT_RATIO_WIDTH, m_game_layer); Config::GFX_CUSTOM_ASPECT_RATIO_WIDTH, m_game_layer);
m_custom_aspect_height = new ConfigInteger(1, MAX_CUSTOM_ASPECT_RATIO_RESOLUTION, m_custom_aspect_height = new ConfigInteger(1, MAX_CUSTOM_ASPECT_RATIO_RESOLUTION,
Config::GFX_CUSTOM_ASPECT_RATIO_HEIGHT, m_game_layer); Config::GFX_CUSTOM_ASPECT_RATIO_HEIGHT, m_game_layer);
ToggleCustomAspectRatio(m_aspect_combo->currentIndex());
m_adapter_combo = new ToolTipComboBox; m_adapter_combo = new ToolTipComboBox;
m_enable_vsync = new ConfigBool(tr("V-Sync"), Config::GFX_VSYNC, m_game_layer); m_enable_vsync = new ConfigBool(tr("V-Sync"), Config::GFX_VSYNC, m_game_layer);
m_enable_fullscreen = m_enable_fullscreen =
@ -169,14 +171,17 @@ void GeneralWidget::ConnectWidgets()
Config::SetBaseOrCurrent(Config::GFX_ADAPTER, index); Config::SetBaseOrCurrent(Config::GFX_ADAPTER, index);
emit BackendChanged(QString::fromStdString(Config::Get(Config::MAIN_GFX_BACKEND))); emit BackendChanged(QString::fromStdString(Config::Get(Config::MAIN_GFX_BACKEND)));
}); });
connect(m_aspect_combo, qOverload<int>(&QComboBox::currentIndexChanged), this, [&](int index) { connect(m_aspect_combo, &QComboBox::currentIndexChanged, this,
const bool is_custom_aspect_ratio = (index == static_cast<int>(AspectMode::Custom)) || &GeneralWidget::ToggleCustomAspectRatio);
(index == static_cast<int>(AspectMode::CustomStretch)); }
m_custom_aspect_label->setHidden(!is_custom_aspect_ratio);
m_custom_aspect_width->setHidden(!is_custom_aspect_ratio); void GeneralWidget::ToggleCustomAspectRatio(int index)
m_custom_aspect_height->setHidden(!is_custom_aspect_ratio); {
}); const bool is_custom_aspect_ratio = (index == static_cast<int>(AspectMode::Custom)) ||
m_aspect_combo->currentIndexChanged(m_aspect_combo->currentIndex()); (index == static_cast<int>(AspectMode::CustomStretch));
m_custom_aspect_label->setHidden(!is_custom_aspect_ratio);
m_custom_aspect_width->setHidden(!is_custom_aspect_ratio);
m_custom_aspect_height->setHidden(!is_custom_aspect_ratio);
} }
void GeneralWidget::BackendWarning() void GeneralWidget::BackendWarning()

1
Source/Core/DolphinQt/Config/Graphics/GeneralWidget.h
View File

@ -40,6 +40,7 @@ private:
void BackendWarning(); void BackendWarning();
void CreateWidgets(); void CreateWidgets();
void ToggleCustomAspectRatio(int index);
void ConnectWidgets(); void ConnectWidgets();
void AddDescriptions(); void AddDescriptions();