mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2024-11-14 21:37:52 -07:00
NetPlayServer: Possible out-of-bounds access on invalid input
if a pad or wiimote number was outside bounds (e.g. 42353543232), it would still have been read from the array, which could lead to inappropriate consequences, like a segfault.
This commit is contained in:
parent
8e1be37feb
commit
1c808a2835
@ -504,8 +504,10 @@ unsigned int NetPlayServer::OnData(sf::Packet& packet, Client& player)
|
|||||||
|
|
||||||
// If the data is not from the correct player,
|
// If the data is not from the correct player,
|
||||||
// then disconnect them.
|
// then disconnect them.
|
||||||
if (m_pad_map[map] != player.pid)
|
if (m_pad_map.at(map) != player.pid)
|
||||||
|
{
|
||||||
return 1;
|
return 1;
|
||||||
|
}
|
||||||
|
|
||||||
// Relay to clients
|
// Relay to clients
|
||||||
sf::Packet spac;
|
sf::Packet spac;
|
||||||
@ -531,7 +533,7 @@ unsigned int NetPlayServer::OnData(sf::Packet& packet, Client& player)
|
|||||||
|
|
||||||
// If the data is not from the correct player,
|
// If the data is not from the correct player,
|
||||||
// then disconnect them.
|
// then disconnect them.
|
||||||
if (m_wiimote_map[map] != player.pid)
|
if (m_wiimote_map.at(map) != player.pid)
|
||||||
{
|
{
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user