piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-26 07:39:45 -06:00
Code Issues Packages Projects Releases Wiki Activity

BPMemory: Eliminate union type punning

Browse Source 
This is undefined behavior in C++.
This commit is contained in:
Lioncash
2017-01-23 15:48:14 -05:00
parent 98311cd9f4
commit 1f596a23af
2 changed files with 26 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
Source/Core/VideoCommon/BPMemory.h
View File

@ -674,17 +674,7 @@ union FogParam0
u32 sign : 1;
};
float GetA()
{
union
{
u32 i;
float f;
} dummy;
dummy.i = ((u32)sign << 31) | ((u32)exponent << 23) |
((u32)mantissa << 12); // scale mantissa from 11 to 23 bits
return dummy.f;
}
float GetA() const;
u32 hex;
};
@ -701,17 +691,7 @@ union FogParam3
};
// amount to subtract from eyespacez after range adjustment
float GetC()
{
union
{
u32 i;
float f;
} dummy;
dummy.i = ((u32)c_sign << 31) | ((u32)c_exp << 23) |
((u32)c_mant << 12); // scale mantissa from 11 to 23 bits
return dummy.f;
}
float GetC() const;
u32 hex;
};