piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 06:39:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

VertexManagerBase: Make CreateNativeVertexFormat return a unique_ptr

Browse Source 
Much safer as opposed to just returning raw allocated memory.
This commit is contained in:
Lioncash
2017-02-18 03:14:30 -05:00
parent 82734fffaa
commit 1fa81f24d3
15 changed files with 36 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/VideoBackends/OGL/NativeVertexFormat.cpp
View File

@ -17,10 +17,10 @@
namespace OGL
{
NativeVertexFormat*
std::unique_ptr<NativeVertexFormat>
VertexManager::CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl)
{
return new GLVertexFormat(vtx_decl);
return std::make_unique<GLVertexFormat>(vtx_decl);
}
static inline GLuint VarToGL(VarType t)

6
Source/Core/VideoBackends/OGL/VertexManager.h
View File

@ -4,6 +4,7 @@
#pragma once
#include <memory>
#include <vector>
#include "Common/CommonTypes.h"
@ -31,7 +32,10 @@ class VertexManager : public VertexManagerBase
public:
VertexManager();
~VertexManager();
NativeVertexFormat* CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl) override;
std::unique_ptr<NativeVertexFormat>
CreateNativeVertexFormat(const PortableVertexDeclaration& vtx_decl) override;
void CreateDeviceObjects() override;
void DestroyDeviceObjects() override;