piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-28 09:59:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Do not accept on hotkey syntax errors

Browse Source 
Previously you could type whatever gibberish you wanted into the formula bar, press OK, and receive a modal syntax error window. Closing the syntax error window would cause the hotkey config window to close as well, and your gibberish would be applied to the hotkey assignment.

This commit requires that a syntax error does not occur before accept() is called.
This commit is contained in:
sowens99
2021-09-27 14:28:08 -04:00
parent 753a1595bf
commit 242bce27a1
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/DolphinQt/Config/Mapping/IOWindow.cpp
View File

@ -515,9 +515,11 @@ void IOWindow::OnDialogButtonPressed(QAbstractButton* button)
{
ModalMessageBox::warning(this, tr("Error"), tr("The expression contains a syntax error."));
}
// must be the OK button
accept();
else
{
// must be the OK button
accept();
}
}
void IOWindow::OnDetectButtonPressed()