From 28e93827dbbb36e7dd76079a8953a82deb6bc21b Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 23 Jan 2024 16:19:21 -0500 Subject: [PATCH 1/2] EXI_DeviceAGP: Annotate fallthrough with [[fallthrough]] Same behavior, but eleminates compiler warnings. --- Source/Core/Core/HW/EXI/EXI_DeviceAGP.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/Core/HW/EXI/EXI_DeviceAGP.cpp b/Source/Core/Core/HW/EXI/EXI_DeviceAGP.cpp index a4b51e2fea..f035003cf0 100644 --- a/Source/Core/Core/HW/EXI/EXI_DeviceAGP.cpp +++ b/Source/Core/Core/HW/EXI/EXI_DeviceAGP.cpp @@ -344,10 +344,10 @@ void CEXIAgp::ImmWrite(u32 _uData, u32 _uSize) case 0xAE010000: case 0xAE090000: // start DMA m_eeprom_write_status = false; // ToDo: Verify with hardware which commands disable EEPROM CS - // Fall-through intentional + [[fallthrough]]; case 0xAE0A0000: // end DMA m_eeprom_pos = 0; - // Fall-through intentional + [[fallthrough]]; default: m_current_cmd = _uData; m_return_pos = 0; From adb79d4e32393c4a3db128dfbaf440a7539b0d53 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 23 Jan 2024 16:22:08 -0500 Subject: [PATCH 2/2] WiimoteReal: Explicitly break instead of fallthrough in IsBalanceBoard() Same behavior, no compiler warnings. --- Source/Core/Core/HW/WiimoteReal/WiimoteReal.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Source/Core/Core/HW/WiimoteReal/WiimoteReal.cpp b/Source/Core/Core/HW/WiimoteReal/WiimoteReal.cpp index 213873b61c..10d4beb329 100644 --- a/Source/Core/Core/HW/WiimoteReal/WiimoteReal.cpp +++ b/Source/Core/Core/HW/WiimoteReal/WiimoteReal.cpp @@ -419,6 +419,7 @@ bool Wiimote::IsBalanceBoard() "Failed to read from 0xa400fe, assuming Wiimote is not a Balance Board."); return false; } + break; } default: break;