From 2b877fc92bce9b821306c8521408419f5ed1b2c6 Mon Sep 17 00:00:00 2001 From: Lioncache Date: Mon, 18 Dec 2023 10:11:47 -0500 Subject: [PATCH] Core/IOS/Top: Make use of fmt::format_to_n where applicable Same behavior, but avoids deprecation warnings on macOS builds and also lets us use generic print formatting. --- Source/Core/Core/IOS/Network/IP/Top.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Source/Core/Core/IOS/Network/IP/Top.cpp b/Source/Core/Core/IOS/Network/IP/Top.cpp index 12a6cda53b..1cf70e8df3 100644 --- a/Source/Core/Core/IOS/Network/IP/Top.cpp +++ b/Source/Core/Core/IOS/Network/IP/Top.cpp @@ -667,10 +667,11 @@ IPCReply NetIPTopDevice::HandleInetNToPRequest(const IOCtlRequest& request) // u32 validAddress = memory.Read_U32(request.buffer_in + 4); // u32 src = memory.Read_U32(request.buffer_in + 8); - char ip_s[16]; - sprintf(ip_s, "%i.%i.%i.%i", memory.Read_U8(request.buffer_in + 8), - memory.Read_U8(request.buffer_in + 8 + 1), memory.Read_U8(request.buffer_in + 8 + 2), - memory.Read_U8(request.buffer_in + 8 + 3)); + char ip_s[16]{}; + fmt::format_to_n(ip_s, sizeof(ip_s) - 1, "{}.{}.{}.{}", memory.Read_U8(request.buffer_in + 8), + memory.Read_U8(request.buffer_in + 8 + 1), + memory.Read_U8(request.buffer_in + 8 + 2), + memory.Read_U8(request.buffer_in + 8 + 3)); INFO_LOG_FMT(IOS_NET, "IOCTL_SO_INETNTOP {}", ip_s); memory.CopyToEmu(request.buffer_out, reinterpret_cast(ip_s), std::strlen(ip_s));