piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-25 07:09:48 -06:00
Code Issues Packages Projects Releases Wiki Activity

AchievementManager: Replace memsets where applicable

Browse Source 
We can just use brace initialization to zero these out. Smaller to
write and a little quicker to read.
This commit is contained in:
Lioncash
2024-01-31 22:34:50 -05:00
parent 184fe932ed
commit 2d8af7b7f8
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/Core/AchievementManager.cpp
View File

@ -911,7 +911,7 @@ void AchievementManager::CloseGame()
m_unlock_map.clear(); m_unlock_map.clear();
m_leaderboard_map.clear(); m_leaderboard_map.clear();
rc_api_destroy_fetch_game_data_response(&m_game_data); rc_api_destroy_fetch_game_data_response(&m_game_data);
std::memset(&m_game_data, 0, sizeof(m_game_data)); m_game_data = {};
m_queue.Cancel(); m_queue.Cancel();
m_image_queue.Cancel(); m_image_queue.Cancel();
m_system = nullptr; m_system = nullptr;
@ -1134,7 +1134,7 @@ AchievementManager::ResponseType AchievementManager::FetchGameData()
game_id, api_request.url, game_id, api_request.url,
api_request.post_data == nullptr ? "NULL" : api_request.post_data, response_str); api_request.post_data == nullptr ? "NULL" : api_request.post_data, response_str);
rc_api_destroy_fetch_game_data_response(&m_game_data); rc_api_destroy_fetch_game_data_response(&m_game_data);
std::memset(&m_game_data, 0, sizeof(m_game_data)); m_game_data = {};
return ResponseType::MALFORMED_OBJECT; return ResponseType::MALFORMED_OBJECT;
} }
if (!m_game_data.response.succeeded) if (!m_game_data.response.succeeded)
@ -1146,7 +1146,7 @@ AchievementManager::ResponseType AchievementManager::FetchGameData()
// Logout technically does this via a CloseGame call, but doing this now prevents the activate // Logout technically does this via a CloseGame call, but doing this now prevents the activate
// methods from thinking they have something to do. // methods from thinking they have something to do.
rc_api_destroy_fetch_game_data_response(&m_game_data); rc_api_destroy_fetch_game_data_response(&m_game_data);
std::memset(&m_game_data, 0, sizeof(m_game_data)); m_game_data = {};
Logout(); Logout();
return ResponseType::INVALID_CREDENTIALS; return ResponseType::INVALID_CREDENTIALS;
} }
@ -1156,7 +1156,7 @@ AchievementManager::ResponseType AchievementManager::FetchGameData()
"Attempted to retrieve game data for ID {}; running game is now ID {}", game_id, "Attempted to retrieve game data for ID {}; running game is now ID {}", game_id,
m_game_id); m_game_id);
rc_api_destroy_fetch_game_data_response(&m_game_data); rc_api_destroy_fetch_game_data_response(&m_game_data);
std::memset(&m_game_data, 0, sizeof(m_game_data)); m_game_data = {};
return ResponseType::EXPIRED_CONTEXT; return ResponseType::EXPIRED_CONTEXT;
} }
INFO_LOG_FMT(ACHIEVEMENTS, "Retrieved game data for ID {}.", game_id); INFO_LOG_FMT(ACHIEVEMENTS, "Retrieved game data for ID {}.", game_id);