mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-07-22 05:40:01 -06:00
DolphinQt: Show a warning when launching an NKit disc image
It is my opinion that nobody should use NKit disc images without being aware of the drawbacks of them. Since it seems like almost nobody who is using NKit disc images knows what NKit is (hmm, now how could that have happened...?), I am adding a warning to Dolphin so that you can't run NKit disc images without finding out about the drawbacks. In case someone really does want to use NKit disc images, the warning has a "Don't show this again" option. Unfortunately, I can't retroactively add the warning where it's most needed: in Dolphin 5.0, which does not support Wii NKit disc images.
This commit is contained in:
@ -988,22 +988,18 @@ void VolumeVerifier::CheckMisc()
|
||||
}
|
||||
}
|
||||
|
||||
if (IsDisc(m_volume.GetVolumeType()))
|
||||
if (m_volume.IsNKit())
|
||||
{
|
||||
constexpr u32 NKIT_MAGIC = 0x4E4B4954; // "NKIT"
|
||||
if (m_volume.ReadSwapped<u32>(0x200, PARTITION_NONE) == NKIT_MAGIC)
|
||||
{
|
||||
AddProblem(
|
||||
Severity::Low,
|
||||
Common::GetStringT("This disc image is in the NKit format. It is not a good dump in its "
|
||||
"current form, but it might become a good dump if converted back. "
|
||||
"The CRC32 of this file might match the CRC32 of a good dump even "
|
||||
"though the files are not identical."));
|
||||
}
|
||||
|
||||
if (StringBeginsWith(game_id_unencrypted, "R8P"))
|
||||
CheckSuperPaperMario();
|
||||
AddProblem(
|
||||
Severity::Low,
|
||||
Common::GetStringT("This disc image is in the NKit format. It is not a good dump in its "
|
||||
"current form, but it might become a good dump if converted back. "
|
||||
"The CRC32 of this file might match the CRC32 of a good dump even "
|
||||
"though the files are not identical."));
|
||||
}
|
||||
|
||||
if (IsDisc(m_volume.GetVolumeType()) && StringBeginsWith(game_id_unencrypted, "R8P"))
|
||||
CheckSuperPaperMario();
|
||||
}
|
||||
|
||||
void VolumeVerifier::CheckSuperPaperMario()
|
||||
|
Reference in New Issue
Block a user