Fix some cases of variables being used uninitialized. Also some unused

variables, writeable strings and dangerously shadowed variables.

index(), gamma(), exp() and y0() are POSIX functions and using those
names can cause namespace confusion.

A number of C files were missing the final newline required by ANSI C
and some versions of GCC are pedantic enough to complain about this.

These changes simply the scons build, allowing us to get rid of
filterWarnings which is simply more trouble than it's worth.


git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@5574 8ced0084-cf51-0410-be5f-012b33b47a6e

Source/TestSuite/ASM/source/Defines.h

@@ -5,4 +5,4 @@
 #define u8 unsigned char
 #define s8 signed char
 #define s16 signed short
-#define s32 signed int
+#define s32 signed int

Source/TestSuite/ASM/source/Helpers.cpp

@@ -56,4 +56,4 @@ u32 GetXER()
 		: "=&r"(var)
 		);
 	return var;
-}
+}

Source/TestSuite/ASM/source/Helpers.h

@@ -2,4 +2,4 @@
 
 u32 GetCR0();
 u32 GetCR(u32 num);
-u32 GetXER();
+u32 GetXER();

Source/TestSuite/ASM/source/Instructions.h

@@ -17,4 +17,4 @@ void divwoRC(u32 *a, u32 *b, u32 *c, u32 *d);
 
 void fsqrt(float *a, float *b, float *c, float *d);
 
-void fsqrtRC(float *a, float *b, float *c, float *d);
+void fsqrtRC(float *a, float *b, float *c, float *d);

Source/TestSuite/ASM/source/asm_float.cpp

@@ -13,4 +13,4 @@ void fsqrtRC(float *a, float *b, float *c, float *d)
 		"fsqrt. fr0,%0"
 		: "=&r"(*a)
 		);*/
-}
+}

Source/TestSuite/ASM/source/asm_integer.cpp

@@ -71,4 +71,4 @@ void divwoRC(u32 *a, u32 *b, u32 *c, u32 *d)
 		: "r"(*b), "r"(*c)
 		: "cc"
 		);
-}
+}

Source/TestSuite/ASM/source/asm_tables.cpp

@@ -185,4 +185,4 @@ void RunInstruction(u32 inst)
 	}
 	if(f)
 		fclose(f);
-}
+}

Source/TestSuite/ASM/source/asm_tables.h

@@ -49,4 +49,4 @@ static inst instructions[] = {
 };
 
 
-void RunInstruction(u32 inst);
+void RunInstruction(u32 inst);

Source/TestSuite/ASM/source/dolphintest_asm.cpp

@@ -25,17 +25,6 @@
 #include "asm_tables.h"
 #include "Helpers.h"
 
-#ifdef __APPLE__
-void die(char *msg){}
-
-void initialise_fat(){}
-
-void init_crap(){}
-
-void end(){}
-#endif 
-
-
 FILE *f = NULL;
 int main(int argc, char **argv) {
 	init_crap();

Source/TestSuite/ASM/source/makefile

@@ -1,2 +1,2 @@
 all:
-	g++ -g -arch ppc dolphintest_asm.cpp asm_tables.cpp Helpers.cpp asm_integer.cpp asm_float.cpp -o Test
+	g++ -g -arch ppc dolphintest_asm.cpp asm_tables.cpp Helpers.cpp asm_integer.cpp asm_float.cpp -o Test