piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 06:39:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

MMU: Remove implicit sign conversions and truncation in UpdateTLBEntry

Browse Source 
These are trivial to resolve.

Converting the structure member into a u32 results in no increase in
structure size, as it's making use of the three extra padding bits in
the structure.
This commit is contained in:
Lioncash
2021-08-31 09:55:13 -04:00
parent c008b1c335
commit 3216040bfe
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/Core/PowerPC/MMU.cpp
View File

@ -1282,9 +1282,9 @@ static void UpdateTLBEntry(const XCheckTLBFlag flag, UPTE_Hi pte2, const u32 add
if (IsNoExceptionFlag(flag)) if (IsNoExceptionFlag(flag))
return; return;
const int tag = address >> HW_PAGE_INDEX_SHIFT; const u32 tag = address >> HW_PAGE_INDEX_SHIFT;
TLBEntry& tlbe = ppcState.tlb[IsOpcodeFlag(flag)][tag & HW_PAGE_INDEX_MASK]; TLBEntry& tlbe = ppcState.tlb[IsOpcodeFlag(flag)][tag & HW_PAGE_INDEX_MASK];
const int index = tlbe.recent == 0 && tlbe.tag[0] != TLBEntry::INVALID_TAG; const u32 index = tlbe.recent == 0 && tlbe.tag[0] != TLBEntry::INVALID_TAG;
tlbe.recent = index; tlbe.recent = index;
tlbe.paddr[index] = pte2.RPN << HW_PAGE_INDEX_SHIFT; tlbe.paddr[index] = pte2.RPN << HW_PAGE_INDEX_SHIFT;
tlbe.pte[index] = pte2.Hex; tlbe.pte[index] = pte2.Hex;

2
Source/Core/Core/PowerPC/PowerPC.h
View File

@ -54,7 +54,7 @@ struct TLBEntry
u32 tag[TLB_WAYS] = {INVALID_TAG, INVALID_TAG}; u32 tag[TLB_WAYS] = {INVALID_TAG, INVALID_TAG};
u32 paddr[TLB_WAYS] = {}; u32 paddr[TLB_WAYS] = {};
u32 pte[TLB_WAYS] = {}; u32 pte[TLB_WAYS] = {};
u8 recent = 0; u32 recent = 0;
}; };
struct PairedSingle struct PairedSingle