piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Vulkan: Remove unnecessary command buffer execution

Browse Source 
When resizing the game window there is a chance that the swapchain state
is bad. This will result in a deadlock on Linux + Nvidia's proprietary
driver. This code can be removed and the next command buffer execution
will simply occur when the swapchain has been recreated.

The root issue may be a Linux Nvidia driver implementation problem. I
wasn't able to reproduce the original problem on Windows, nor on my
Steam Deck. I tested this change on Fedora 40+Nvidia & SteamOS+AMD.

Fixes https://bugs.dolphin-emu.org/issues/13523
This commit is contained in:
Ali Homafar 2024-08-28 13:28:55 -04:00
parent 76287f3810
commit 3b92f4928a
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Source/Core/VideoBackends/Vulkan/VKGfx.cpp
View File

@ -260,9 +260,6 @@ bool VKGfx::BindBackbuffer(const ClearColor& clear_color)
if (res != VK_SUCCESS) if (res != VK_SUCCESS)
{ {
// Execute cmdbuffer before resizing, as the last frame could still be presenting.
ExecuteCommandBuffer(false, true);
// Was this a lost exclusive fullscreen? // Was this a lost exclusive fullscreen?
if (res == VK_ERROR_FULL_SCREEN_EXCLUSIVE_MODE_LOST_EXT) if (res == VK_ERROR_FULL_SCREEN_EXCLUSIVE_MODE_LOST_EXT)
{ {