piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-23 14:19:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

don't use std::move on const variables

Browse Source
This commit is contained in:
Shawn Hoffman
2020-08-17 17:23:28 -07:00
parent 1b1fc39f02
commit 3bc8a26083
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/Common/FileSearch.cpp
View File

@ -98,7 +98,7 @@ std::vector<std::string> DoFileSearch(const std::vector<std::string>& directorie
}; };
for (const auto& directory : directories) for (const auto& directory : directories)
{ {
const fs::path directory_path = StringToPath(directory); fs::path directory_path = StringToPath(directory);
if (fs::is_directory(directory_path)) // Can't create iterators for non-existant directories if (fs::is_directory(directory_path)) // Can't create iterators for non-existant directories
{ {
if (recursive) if (recursive)

4
Source/Core/Core/IOS/ES/Formats.cpp
View File

@ -621,7 +621,7 @@ UIDSys::UIDSys(std::shared_ptr<HLE::FS::FileSystem> fs) : m_fs{fs}
{ {
while (true) while (true)
{ {
const std::pair<u32, u64> entry = ReadUidSysEntry(*file); std::pair<u32, u64> entry = ReadUidSysEntry(*file);
if (!entry.first && !entry.second) if (!entry.first && !entry.second)
break; break;
@ -766,7 +766,7 @@ std::map<std::string, CertReader> ParseCertChain(const std::vector<u8>& chain)
return certs; return certs;
processed += cert_reader.GetBytes().size(); processed += cert_reader.GetBytes().size();
const std::string name = cert_reader.GetName(); std::string name = cert_reader.GetName();
certs.emplace(std::move(name), std::move(cert_reader)); certs.emplace(std::move(name), std::move(cert_reader));
} }
return certs; return certs;

2
Source/Core/UICommon/CommandLineParse.cpp
View File

@ -45,7 +45,7 @@ public:
std::getline(buffer, section, '.'); std::getline(buffer, section, '.');
std::getline(buffer, key, '='); std::getline(buffer, key, '=');
std::getline(buffer, value, '='); std::getline(buffer, value, '=');
const std::optional<Config::System> system = Config::GetSystemFromName(system_str); std::optional<Config::System> system = Config::GetSystemFromName(system_str);
if (system) if (system)
{ {
m_values.emplace_back( m_values.emplace_back(