piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-24 06:39:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

Avoid always-true and signed/unsigned comparisons.

Browse Source 
Make empty while loops a little more obvious with a {} suffix.


git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@6019 8ced0084-cf51-0410-be5f-012b33b47a6e
This commit is contained in:
Soren Jorvang
2010-07-31 19:06:44 +00:00
parent 0e83d52382
commit 3d25197a1c
10 changed files with 3795 additions and 3794 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/Common/Src/Log.h
View File

@ -140,8 +140,8 @@ void GenericLogC(int level, int type,
#define _dbg_update_() ;
#ifndef _dbg_assert_
#define _dbg_assert_(_t_, _a_) ;
#define _dbg_assert_msg_(_t_, _a_, _desc_, ...) ;
#define _dbg_assert_(_t_, _a_) {}
#define _dbg_assert_msg_(_t_, _a_, _desc_, ...) {}
#endif // dbg_assert
#endif // MAX_LOGLEVEL DEBUG

2
Source/Core/Core/Src/CoreTiming.cpp
View File

@ -522,7 +522,7 @@ std::string GetScheduledEventsSummary()
while (ptr)
{
unsigned int t = ptr->type;
if (t < 0 || t >= event_types.size())
if (t >= event_types.size())
PanicAlert("Invalid event type %i", t);
const char *name = event_types[ptr->type].name;
if (!name)

2
Source/Core/Core/Src/HW/SI_DeviceAMBaseboard.cpp
View File

@ -299,7 +299,7 @@ int CSIDevice_AMBaseboard::RunBuffer(u8* _pBuffer, int _iLength)
msg.addData((void *)"\x00\x00\x00\x00", 4);
break;
case 0x15:
while (*jvs_io++);
while (*jvs_io++) {};
msg.addData(1);
break;
case 0x20:

4
Source/Core/Core/Src/PowerPC/Jit64/JitRegCache.cpp
View File

@ -330,7 +330,7 @@ void FPURegCache::LoadToX64(int i, bool doLoad, bool makeDirty)
{
// Reg is at home in the memory register file. Let's pull it out.
X64Reg xr = GetFreeXReg();
_assert_msg_(DYNA_REC, xr >= 0 && xr < NUMXREGS, "WTF - load - invalid reg");
_assert_msg_(DYNA_REC, xr < NUMXREGS, "WTF - load - invalid reg");
xregs[xr].ppcReg = i;
xregs[xr].free = false;
xregs[xr].dirty = makeDirty;
@ -357,7 +357,7 @@ void FPURegCache::StoreFromX64(int i)
if (regs[i].away)
{
X64Reg xr = regs[i].location.GetSimpleReg();
_assert_msg_(DYNA_REC, xr >= 0 && xr < NUMXREGS, "WTF - store - invalid reg");
_assert_msg_(DYNA_REC, xr < NUMXREGS, "WTF - store - invalid reg");
xregs[xr].free = true;
xregs[xr].dirty = false;
xregs[xr].ppcReg = -1;