piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

Avoid always-true and signed/unsigned comparisons.

Browse Source 
Make empty while loops a little more obvious with a {} suffix.


git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@6019 8ced0084-cf51-0410-be5f-012b33b47a6e
This commit is contained in:
Soren Jorvang
2010-07-31 19:06:44 +00:00
parent 0e83d52382
commit 3d25197a1c
10 changed files with 3795 additions and 3794 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Plugins/Plugin_DSP_HLE/Src/UCodes/UCode_Zelda.cpp
View File

@ -169,7 +169,7 @@ void CUCode_Zelda::HandleMail_LightVersion(u32 _uMail)
m_step = 0;
}
if (m_step < 0 || m_step >= sizeof(m_Buffer) / 4)
if (m_step >= sizeof(m_Buffer) / 4)
PanicAlert("m_step out of range");
((u32*)m_Buffer)[m_step] = _uMail;
@ -226,7 +226,7 @@ void CUCode_Zelda::HandleMail_SMSVersion(u32 _uMail)
if (m_bListInProgress)
{
if (m_step < 0 || m_step >= sizeof(m_Buffer) / 4)
if (m_step >= sizeof(m_Buffer) / 4)
PanicAlert("m_step out of range");
((u32*)m_Buffer)[m_step] = _uMail;
@ -349,7 +349,7 @@ void CUCode_Zelda::HandleMail_NormalVersion(u32 _uMail)
if (m_bListInProgress)
{
if (m_step < 0 || m_step >= sizeof(m_Buffer) / 4)
if (m_step >= sizeof(m_Buffer) / 4)
PanicAlert("m_step out of range");
((u32*)m_Buffer)[m_step] = _uMail;

4
Source/Plugins/Plugin_WiimoteNew/Src/WiimoteReal/WiimoteReal.cpp
View File

@ -174,7 +174,7 @@ void Wiimote::InterruptChannel(const u16 channel, const void* const data, const
if (0 == m_channel) // first interrupt/control channel sent
{
// clear all msgs, silly maybe
while (wiiuse_io_read(m_wiimote));
while (wiiuse_io_read(m_wiimote)) {};
// request status
wm_request_status rpt = wm_request_status();
@ -251,7 +251,7 @@ void Wiimote::Disconnect()
ClearReports();
// clear out wiiuse queue, or maybe not, silly? idk
while (wiiuse_io_read(m_wiimote));
while (wiiuse_io_read(m_wiimote)) {};
}
Wiimote* g_wiimotes[4];