piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

DolphinQt: Rework TAS input threading, part 1 (buttons)

Browse Source 
This gets rid of a blocking operation, improving performance and fixing
https://bugs.dolphin-emu.org/issues/12893.

This also makes us no longer directly access the state of certain UI
elements from the CPU thread, which probably wasn't thread-safe but
doesn't seem to have caused any observable issues so far.
This commit is contained in:
JosJuice
2023-03-04 12:24:31 +01:00
parent 95ce41ac56
commit 3eac1fc284
8 changed files with 140 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/DolphinQt/TAS/TASCheckBox.h
View File

@ -5,6 +5,8 @@
#include <QCheckBox>
#include "DolphinQt/TAS/TASControlState.h"
class QMouseEvent;
class TASInputWindow;
@ -14,13 +16,21 @@ class TASCheckBox : public QCheckBox
public:
explicit TASCheckBox(const QString& text, TASInputWindow* parent);
// Can be called from the CPU thread
bool GetValue() const;
// Must be called from the CPU thread
void OnControllerValueChanged(bool new_value);
protected:
void mousePressEvent(QMouseEvent* event) override;
private slots:
void OnUIValueChanged(int new_value);
void ApplyControllerValueChange();
private:
const TASInputWindow* m_parent;
TASControlState m_state;
int m_frame_turbo_started = 0;
int m_turbo_press_frames = 0;
int m_turbo_total_frames = 0;