piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #11634 from AdmiralCurtiss/dsp-class

Browse Source 
HW/DSP: Refactor to class.
This commit is contained in:
Mai 2023-03-09 20:06:53 -05:00 committed by GitHub
commit 3ec32c5aa5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
19 changed files with 406 additions and 398 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Source/Core/Core/Core.cpp
View File

@ -568,7 +568,8 @@ static void EmuThread(std::unique_ptr<BootParameters> boot, WindowSystemInfo wsi
else else
Config::SetBaseOrCurrent(Config::MAIN_DSP_THREAD, cpu_info.num_cores > 2); Config::SetBaseOrCurrent(Config::MAIN_DSP_THREAD, cpu_info.num_cores > 2);
if (!DSP::GetDSPEmulator()->Initialize(core_parameter.bWii, Config::Get(Config::MAIN_DSP_THREAD))) if (!system.GetDSP().GetDSPEmulator()->Initialize(core_parameter.bWii,
Config::Get(Config::MAIN_DSP_THREAD)))
{ {
PanicAlertFmt("Failed to initialize DSP emulation!"); PanicAlertFmt("Failed to initialize DSP emulation!");
return; return;
@ -785,7 +786,7 @@ static bool PauseAndLock(Core::System& system, bool do_lock, bool unpause_on_unl
ExpansionInterface::PauseAndLock(do_lock, false); ExpansionInterface::PauseAndLock(do_lock, false);
// audio has to come after CPU, because CPU thread can wait for audio thread (m_throttle). // audio has to come after CPU, because CPU thread can wait for audio thread (m_throttle).
DSP::GetDSPEmulator()->PauseAndLock(do_lock, false); system.GetDSP().GetDSPEmulator()->PauseAndLock(do_lock, false);
// video has to come after CPU, because CPU thread can wait for video thread // video has to come after CPU, because CPU thread can wait for video thread
// (s_efbAccessRequested). // (s_efbAccessRequested).

7
Source/Core/Core/Debugger/PPCDebugInterface.cpp
View File

@ -325,8 +325,11 @@ u32 PPCDebugInterface::ReadExtraMemory(const Core::CPUThreadGuard& guard, int me
case 0: case 0:
return PowerPC::HostRead_U32(guard, address); return PowerPC::HostRead_U32(guard, address);
case 1: case 1:
return (DSP::ReadARAM(address) << 24) | (DSP::ReadARAM(address + 1) << 16) | {
(DSP::ReadARAM(address + 2) << 8) | (DSP::ReadARAM(address + 3)); auto& dsp = Core::System::GetInstance().GetDSP();
return (dsp.ReadARAM(address) << 24) | (dsp.ReadARAM(address + 1) << 16) |
(dsp.ReadARAM(address + 2) << 8) | (dsp.ReadARAM(address + 3));
}
default: default:
return 0; return 0;
} }

11
Source/Core/Core/HW/AddressSpace.cpp
View File

@ -212,19 +212,22 @@ struct AuxiliaryAddressSpaceAccessors : Accessors
} }
u8 ReadU8(const Core::CPUThreadGuard& guard, u32 address) const override u8 ReadU8(const Core::CPUThreadGuard& guard, u32 address) const override
{ {
const u8* base = DSP::GetARAMPtr(); const u8* base = Core::System::GetInstance().GetDSP().GetARAMPtr();
return base[address]; return base[address];
} }
void WriteU8(const Core::CPUThreadGuard& guard, u32 address, u8 value) override void WriteU8(const Core::CPUThreadGuard& guard, u32 address, u8 value) override
{ {
u8* base = DSP::GetARAMPtr(); u8* base = Core::System::GetInstance().GetDSP().GetARAMPtr();
base[address] = value; base[address] = value;
} }
iterator begin() const override { return DSP::GetARAMPtr(); } iterator begin() const override { return Core::System::GetInstance().GetDSP().GetARAMPtr(); }
iterator end() const override { return DSP::GetARAMPtr() + GetSize(); } iterator end() const override
{
return Core::System::GetInstance().GetDSP().GetARAMPtr() + GetSize();
}
std::optional<u32> Search(const Core::CPUThreadGuard& guard, u32 haystack_offset, std::optional<u32> Search(const Core::CPUThreadGuard& guard, u32 haystack_offset,
const u8* needle_start, std::size_t needle_size, const u8* needle_start, std::size_t needle_size,

544
Source/Core/Core/HW/DSP.cpp
View File

@ -68,191 +68,101 @@ enum
AUDIO_DMA_BLOCKS_LEFT = 0x503A, AUDIO_DMA_BLOCKS_LEFT = 0x503A,
}; };
// UARAMCount DSPManager::DSPManager(Core::System& system) : m_system(system)
union UARAMCount
{
u32 Hex = 0;
struct
{
u32 count : 31;
u32 dir : 1; // 0: MRAM -> ARAM 1: ARAM -> MRAM
};
};
// Blocks are 32 bytes.
union UAudioDMAControl
{
u16 Hex = 0;
struct
{
u16 NumBlocks : 15;
u16 Enable : 1;
};
};
// AudioDMA
struct AudioDMA
{
u32 current_source_address = 0;
u16 remaining_blocks_count = 0;
u32 SourceAddress = 0;
UAudioDMAControl AudioDMAControl;
};
// ARAM_DMA
struct ARAM_DMA
{
u32 MMAddr = 0;
u32 ARAddr = 0;
UARAMCount Cnt;
};
// So we may abstract GC/Wii differences a little
struct ARAMInfo
{
bool wii_mode = false; // Wii EXRAM is managed in Memory:: so we need to skip statesaving, etc
u32 size = ARAM_SIZE;
u32 mask = ARAM_MASK;
u8* ptr = nullptr; // aka audio ram, auxiliary ram, MEM2, EXRAM, etc...
};
union ARAM_Info
{
u16 Hex = 0;
struct
{
u16 size : 6;
u16 unk : 1;
u16 : 9;
};
};
struct DSPState::Data
{
ARAMInfo aram;
AudioDMA audio_dma;
ARAM_DMA aram_dma;
UDSPControl dsp_control;
ARAM_Info aram_info;
// Contains bitfields for some stuff we don't care about (and nothing ever reads):
// CAS latency/burst length/addressing mode/write mode
// We care about the LSB tho. It indicates that the ARAM controller has finished initializing
u16 aram_mode = 0;
u16 aram_refresh = 0;
int dsp_slice = 0;
std::unique_ptr<DSPEmulator> dsp_emulator;
bool is_lle = false;
CoreTiming::EventType* event_type_generate_dsp_interrupt = nullptr;
CoreTiming::EventType* event_type_complete_aram = nullptr;
};
DSPState::DSPState() : m_data(std::make_unique<Data>())
{ {
} }
DSPState::~DSPState() = default; DSPManager::~DSPManager() = default;
// time given to LLE DSP on every read of the high bits in a mailbox // time given to LLE DSP on every read of the high bits in a mailbox
constexpr int DSP_MAIL_SLICE = 72; constexpr int DSP_MAIL_SLICE = 72;
void DoState(PointerWrap& p) void DSPManager::DoState(PointerWrap& p)
{ {
auto& state = Core::System::GetInstance().GetDSPState().GetData(); if (!m_aram.wii_mode)
p.DoArray(m_aram.ptr, m_aram.size);
p.Do(m_dsp_control);
p.Do(m_audio_dma);
p.Do(m_aram_dma);
p.Do(m_aram_info);
p.Do(m_aram_mode);
p.Do(m_aram_refresh);
p.Do(m_dsp_slice);
if (!state.aram.wii_mode) m_dsp_emulator->DoState(p);
p.DoArray(state.aram.ptr, state.aram.size);
p.Do(state.dsp_control);
p.Do(state.audio_dma);
p.Do(state.aram_dma);
p.Do(state.aram_info);
p.Do(state.aram_mode);
p.Do(state.aram_refresh);
p.Do(state.dsp_slice);
state.dsp_emulator->DoState(p);
} }
static void UpdateInterrupts(); void DSPManager::GlobalCompleteARAM(Core::System& system, u64 userdata, s64 cyclesLate)
static void Do_ARAM_DMA();
static void GenerateDSPInterrupt(Core::System& system, u64 DSPIntType, s64 cyclesLate = 0);
static void CompleteARAM(Core::System& system, u64 userdata, s64 cyclesLate)
{ {
auto& state = system.GetDSPState().GetData(); system.GetDSP().CompleteARAM(userdata, cyclesLate);
state.dsp_control.DMAState = 0;
GenerateDSPInterrupt(system, INT_ARAM);
} }
DSPEmulator* GetDSPEmulator() void DSPManager::CompleteARAM(u64 userdata, s64 cyclesLate)
{ {
auto& state = Core::System::GetInstance().GetDSPState().GetData(); m_dsp_control.DMAState = 0;
return state.dsp_emulator.get(); GenerateDSPInterrupt(INT_ARAM, 0);
} }
void Init(bool hle) DSPEmulator* DSPManager::GetDSPEmulator()
{
return m_dsp_emulator.get();
}
void DSPManager::Init(bool hle)
{ {
auto& system = Core::System::GetInstance();
auto& core_timing = system.GetCoreTiming();
auto& state = system.GetDSPState().GetData();
Reinit(hle); Reinit(hle);
state.event_type_generate_dsp_interrupt = auto& core_timing = m_system.GetCoreTiming();
core_timing.RegisterEvent("DSPint", GenerateDSPInterrupt); m_event_type_generate_dsp_interrupt =
state.event_type_complete_aram = core_timing.RegisterEvent("ARAMint", CompleteARAM); core_timing.RegisterEvent("DSPint", GlobalGenerateDSPInterrupt);
m_event_type_complete_aram = core_timing.RegisterEvent("ARAMint", GlobalCompleteARAM);
} }
void Reinit(bool hle) void DSPManager::Reinit(bool hle)
{ {
auto& system = Core::System::GetInstance(); m_dsp_emulator = CreateDSPEmulator(hle);
auto& state = system.GetDSPState().GetData(); m_is_lle = m_dsp_emulator->IsLLE();
state.dsp_emulator = CreateDSPEmulator(hle);
state.is_lle = state.dsp_emulator->IsLLE();
if (SConfig::GetInstance().bWii) if (SConfig::GetInstance().bWii)
{ {
auto& memory = system.GetMemory(); auto& memory = m_system.GetMemory();
state.aram.wii_mode = true; m_aram.wii_mode = true;
state.aram.size = memory.GetExRamSizeReal(); m_aram.size = memory.GetExRamSizeReal();
state.aram.mask = memory.GetExRamMask(); m_aram.mask = memory.GetExRamMask();
state.aram.ptr = memory.GetEXRAM(); m_aram.ptr = memory.GetEXRAM();
} }
else else
{ {
// On the GameCube, ARAM is accessible only through this interface. // On the GameCube, ARAM is accessible only through this interface.
state.aram.wii_mode = false; m_aram.wii_mode = false;
state.aram.size = ARAM_SIZE; m_aram.size = ARAM_SIZE;
state.aram.mask = ARAM_MASK; m_aram.mask = ARAM_MASK;
state.aram.ptr = static_cast<u8*>(Common::AllocateMemoryPages(state.aram.size)); m_aram.ptr = static_cast<u8*>(Common::AllocateMemoryPages(m_aram.size));
} }
state.audio_dma = {}; m_audio_dma = {};
state.aram_dma = {}; m_aram_dma = {};
state.dsp_control.Hex = 0; m_dsp_control.Hex = 0;
state.dsp_control.DSPHalt = 1; m_dsp_control.DSPHalt = 1;
state.aram_info.Hex = 0; m_aram_info.Hex = 0;
state.aram_mode = 1; // ARAM Controller has init'd m_aram_mode = 1; // ARAM Controller has init'd
state.aram_refresh = 156; // 156MHz m_aram_refresh = 156; // 156MHz
} }
void Shutdown() void DSPManager::Shutdown()
{ {
auto& state = Core::System::GetInstance().GetDSPState().GetData(); if (!m_aram.wii_mode)
if (!state.aram.wii_mode)
{ {
Common::FreeMemoryPages(state.aram.ptr, state.aram.size); Common::FreeMemoryPages(m_aram.ptr, m_aram.size);
state.aram.ptr = nullptr; m_aram.ptr = nullptr;
} }
state.dsp_emulator->Shutdown(); m_dsp_emulator->Shutdown();
state.dsp_emulator.reset(); m_dsp_emulator.reset();
} }
void RegisterMMIO(MMIO::Mapping* mmio, u32 base) void DSPManager::RegisterMMIO(MMIO::Mapping* mmio, u32 base)
{ {
static constexpr u16 WMASK_NONE = 0x0000; static constexpr u16 WMASK_NONE = 0x0000;
static constexpr u16 WMASK_AR_INFO = 0x007f; static constexpr u16 WMASK_AR_INFO = 0x007f;
@ -263,8 +173,6 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base)
static constexpr u16 WMASK_AUDIO_HI_RESTRICT_WII = 0x1fff; static constexpr u16 WMASK_AUDIO_HI_RESTRICT_WII = 0x1fff;
static constexpr u16 WMASK_LO_ALIGN_32BIT = 0xffe0; static constexpr u16 WMASK_LO_ALIGN_32BIT = 0xffe0;
auto& state = Core::System::GetInstance().GetDSPState().GetData();
// Declare all the boilerplate direct MMIOs. // Declare all the boilerplate direct MMIOs.
struct struct
{ {
@ -273,28 +181,27 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base)
u16 wmask; u16 wmask;
} directly_mapped_vars[] = { } directly_mapped_vars[] = {
// This register is read-only // This register is read-only
{AR_MODE, &state.aram_mode, WMASK_NONE}, {AR_MODE, &m_aram_mode, WMASK_NONE},
// For these registers, only some bits can be set // For these registers, only some bits can be set
{AR_INFO, &state.aram_info.Hex, WMASK_AR_INFO}, {AR_INFO, &m_aram_info.Hex, WMASK_AR_INFO},
{AR_REFRESH, &state.aram_refresh, WMASK_AR_REFRESH}, {AR_REFRESH, &m_aram_refresh, WMASK_AR_REFRESH},
// For AR_DMA_*_H registers, only bits 0x03ff can be set // For AR_DMA_*_H registers, only bits 0x03ff can be set
// For AR_DMA_*_L registers, only bits 0xffe0 can be set // For AR_DMA_*_L registers, only bits 0xffe0 can be set
{AR_DMA_MMADDR_H, MMIO::Utils::HighPart(&state.aram_dma.MMAddr), WMASK_AR_HI_RESTRICT}, {AR_DMA_MMADDR_H, MMIO::Utils::HighPart(&m_aram_dma.MMAddr), WMASK_AR_HI_RESTRICT},
{AR_DMA_MMADDR_L, MMIO::Utils::LowPart(&state.aram_dma.MMAddr), WMASK_LO_ALIGN_32BIT}, {AR_DMA_MMADDR_L, MMIO::Utils::LowPart(&m_aram_dma.MMAddr), WMASK_LO_ALIGN_32BIT},
{AR_DMA_ARADDR_H, MMIO::Utils::HighPart(&state.aram_dma.ARAddr), WMASK_AR_HI_RESTRICT}, {AR_DMA_ARADDR_H, MMIO::Utils::HighPart(&m_aram_dma.ARAddr), WMASK_AR_HI_RESTRICT},
{AR_DMA_ARADDR_L, MMIO::Utils::LowPart(&state.aram_dma.ARAddr), WMASK_LO_ALIGN_32BIT}, {AR_DMA_ARADDR_L, MMIO::Utils::LowPart(&m_aram_dma.ARAddr), WMASK_LO_ALIGN_32BIT},
// For this register, the topmost (dir) bit can also be set // For this register, the topmost (dir) bit can also be set
{AR_DMA_CNT_H, MMIO::Utils::HighPart(&state.aram_dma.Cnt.Hex), {AR_DMA_CNT_H, MMIO::Utils::HighPart(&m_aram_dma.Cnt.Hex),
WMASK_AR_HI_RESTRICT | WMASK_AR_CNT_DIR_BIT}, WMASK_AR_HI_RESTRICT | WMASK_AR_CNT_DIR_BIT},
// AR_DMA_CNT_L triggers DMA // AR_DMA_CNT_L triggers DMA
// For AUDIO_DMA_START_HI, only bits 0x03ff can be set on GCN and 0x1fff on Wii // For AUDIO_DMA_START_HI, only bits 0x03ff can be set on GCN and 0x1fff on Wii
// For AUDIO_DMA_START_LO, only bits 0xffe0 can be set // For AUDIO_DMA_START_LO, only bits 0xffe0 can be set
// AUDIO_DMA_START_HI requires a complex write handler // AUDIO_DMA_START_HI requires a complex write handler
{AUDIO_DMA_START_LO, MMIO::Utils::LowPart(&state.audio_dma.SourceAddress), {AUDIO_DMA_START_LO, MMIO::Utils::LowPart(&m_audio_dma.SourceAddress), WMASK_LO_ALIGN_32BIT},
WMASK_LO_ALIGN_32BIT},
}; };
for (auto& mapped_var : directly_mapped_vars) for (auto& mapped_var : directly_mapped_vars)
{ {
@ -306,137 +213,137 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base)
// DSP mail MMIOs call DSP emulator functions to get results or write data. // DSP mail MMIOs call DSP emulator functions to get results or write data.
mmio->Register(base | DSP_MAIL_TO_DSP_HI, MMIO::ComplexRead<u16>([](Core::System& system, u32) { mmio->Register(base | DSP_MAIL_TO_DSP_HI, MMIO::ComplexRead<u16>([](Core::System& system, u32) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
if (state_.dsp_slice > DSP_MAIL_SLICE && state_.is_lle) if (dsp.m_dsp_slice > DSP_MAIL_SLICE && dsp.m_is_lle)
{ {
state_.dsp_emulator->DSP_Update(DSP_MAIL_SLICE); dsp.m_dsp_emulator->DSP_Update(DSP_MAIL_SLICE);
state_.dsp_slice -= DSP_MAIL_SLICE; dsp.m_dsp_slice -= DSP_MAIL_SLICE;
} }
return state_.dsp_emulator->DSP_ReadMailBoxHigh(true); return dsp.m_dsp_emulator->DSP_ReadMailBoxHigh(true);
}), }),
MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) { MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
state_.dsp_emulator->DSP_WriteMailBoxHigh(true, val); dsp.m_dsp_emulator->DSP_WriteMailBoxHigh(true, val);
})); }));
mmio->Register(base | DSP_MAIL_TO_DSP_LO, MMIO::ComplexRead<u16>([](Core::System& system, u32) { mmio->Register(base | DSP_MAIL_TO_DSP_LO, MMIO::ComplexRead<u16>([](Core::System& system, u32) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
return state_.dsp_emulator->DSP_ReadMailBoxLow(true); return dsp.m_dsp_emulator->DSP_ReadMailBoxLow(true);
}), }),
MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) { MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
state_.dsp_emulator->DSP_WriteMailBoxLow(true, val); dsp.m_dsp_emulator->DSP_WriteMailBoxLow(true, val);
})); }));
mmio->Register(base | DSP_MAIL_FROM_DSP_HI, MMIO::ComplexRead<u16>([](Core::System& system, u32) { mmio->Register(base | DSP_MAIL_FROM_DSP_HI, MMIO::ComplexRead<u16>([](Core::System& system, u32) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
if (state_.dsp_slice > DSP_MAIL_SLICE && state_.is_lle) if (dsp.m_dsp_slice > DSP_MAIL_SLICE && dsp.m_is_lle)
{ {
state_.dsp_emulator->DSP_Update(DSP_MAIL_SLICE); dsp.m_dsp_emulator->DSP_Update(DSP_MAIL_SLICE);
state_.dsp_slice -= DSP_MAIL_SLICE; dsp.m_dsp_slice -= DSP_MAIL_SLICE;
} }
return state_.dsp_emulator->DSP_ReadMailBoxHigh(false); return dsp.m_dsp_emulator->DSP_ReadMailBoxHigh(false);
}), }),
MMIO::InvalidWrite<u16>()); MMIO::InvalidWrite<u16>());
mmio->Register(base | DSP_MAIL_FROM_DSP_LO, MMIO::ComplexRead<u16>([](Core::System& system, u32) { mmio->Register(base | DSP_MAIL_FROM_DSP_LO, MMIO::ComplexRead<u16>([](Core::System& system, u32) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
return state_.dsp_emulator->DSP_ReadMailBoxLow(false); return dsp.m_dsp_emulator->DSP_ReadMailBoxLow(false);
}), }),
MMIO::InvalidWrite<u16>()); MMIO::InvalidWrite<u16>());
mmio->Register( mmio->Register(
base | DSP_CONTROL, MMIO::ComplexRead<u16>([](Core::System& system, u32) { base | DSP_CONTROL, MMIO::ComplexRead<u16>([](Core::System& system, u32) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
return (state_.dsp_control.Hex & ~DSP_CONTROL_MASK) | return (dsp.m_dsp_control.Hex & ~DSP_CONTROL_MASK) |
(state_.dsp_emulator->DSP_ReadControlRegister() & DSP_CONTROL_MASK); (dsp.m_dsp_emulator->DSP_ReadControlRegister() & DSP_CONTROL_MASK);
}), }),
MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) { MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
UDSPControl tmpControl; UDSPControl tmpControl;
tmpControl.Hex = (val & ~DSP_CONTROL_MASK) | tmpControl.Hex = (val & ~DSP_CONTROL_MASK) |
(state_.dsp_emulator->DSP_WriteControlRegister(val) & DSP_CONTROL_MASK); (dsp.m_dsp_emulator->DSP_WriteControlRegister(val) & DSP_CONTROL_MASK);
// Not really sure if this is correct, but it works... // Not really sure if this is correct, but it works...
// Kind of a hack because DSP_CONTROL_MASK should make this bit // Kind of a hack because DSP_CONTROL_MASK should make this bit
// only viewable to DSP emulator // only viewable to DSP emulator
if (val & 1 /*DSPReset*/) if (val & 1 /*DSPReset*/)
{ {
state_.audio_dma.AudioDMAControl.Hex = 0; dsp.m_audio_dma.AudioDMAControl.Hex = 0;
} }
// Update DSP related flags // Update DSP related flags
state_.dsp_control.DSPReset = tmpControl.DSPReset; dsp.m_dsp_control.DSPReset = tmpControl.DSPReset;
state_.dsp_control.DSPAssertInt = tmpControl.DSPAssertInt; dsp.m_dsp_control.DSPAssertInt = tmpControl.DSPAssertInt;
state_.dsp_control.DSPHalt = tmpControl.DSPHalt; dsp.m_dsp_control.DSPHalt = tmpControl.DSPHalt;
state_.dsp_control.DSPInitCode = tmpControl.DSPInitCode; dsp.m_dsp_control.DSPInitCode = tmpControl.DSPInitCode;
state_.dsp_control.DSPInit = tmpControl.DSPInit; dsp.m_dsp_control.DSPInit = tmpControl.DSPInit;
// Interrupt (mask) // Interrupt (mask)
state_.dsp_control.AID_mask = tmpControl.AID_mask; dsp.m_dsp_control.AID_mask = tmpControl.AID_mask;
state_.dsp_control.ARAM_mask = tmpControl.ARAM_mask; dsp.m_dsp_control.ARAM_mask = tmpControl.ARAM_mask;
state_.dsp_control.DSP_mask = tmpControl.DSP_mask; dsp.m_dsp_control.DSP_mask = tmpControl.DSP_mask;
// Interrupt // Interrupt
if (tmpControl.AID) if (tmpControl.AID)
state_.dsp_control.AID = 0; dsp.m_dsp_control.AID = 0;
if (tmpControl.ARAM) if (tmpControl.ARAM)
state_.dsp_control.ARAM = 0; dsp.m_dsp_control.ARAM = 0;
if (tmpControl.DSP) if (tmpControl.DSP)
state_.dsp_control.DSP = 0; dsp.m_dsp_control.DSP = 0;
// unknown // unknown
state_.dsp_control.pad = tmpControl.pad; dsp.m_dsp_control.pad = tmpControl.pad;
if (state_.dsp_control.pad != 0) if (dsp.m_dsp_control.pad != 0)
{ {
PanicAlertFmt( PanicAlertFmt(
"DSPInterface (w) DSP state (CC00500A) gets a value with junk in the padding {:08x}", "DSPInterface (w) DSP state (CC00500A) gets a value with junk in the padding {:08x}",
val); val);
} }
UpdateInterrupts(); dsp.UpdateInterrupts();
})); }));
// ARAM MMIO controlling the DMA start. // ARAM MMIO controlling the DMA start.
mmio->Register(base | AR_DMA_CNT_L, mmio->Register(base | AR_DMA_CNT_L,
MMIO::DirectRead<u16>(MMIO::Utils::LowPart(&state.aram_dma.Cnt.Hex)), MMIO::DirectRead<u16>(MMIO::Utils::LowPart(&m_aram_dma.Cnt.Hex)),
MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) { MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
state_.aram_dma.Cnt.Hex = dsp.m_aram_dma.Cnt.Hex =
(state_.aram_dma.Cnt.Hex & 0xFFFF0000) | (val & WMASK_LO_ALIGN_32BIT); (dsp.m_aram_dma.Cnt.Hex & 0xFFFF0000) | (val & WMASK_LO_ALIGN_32BIT);
Do_ARAM_DMA(); dsp.Do_ARAM_DMA();
})); }));
mmio->Register(base | AUDIO_DMA_START_HI, mmio->Register(base | AUDIO_DMA_START_HI,
MMIO::DirectRead<u16>(MMIO::Utils::HighPart(&state.audio_dma.SourceAddress)), MMIO::DirectRead<u16>(MMIO::Utils::HighPart(&m_audio_dma.SourceAddress)),
MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) { MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
*MMIO::Utils::HighPart(&state_.audio_dma.SourceAddress) = *MMIO::Utils::HighPart(&dsp.m_audio_dma.SourceAddress) =
val & (SConfig::GetInstance().bWii ? WMASK_AUDIO_HI_RESTRICT_WII : val & (SConfig::GetInstance().bWii ? WMASK_AUDIO_HI_RESTRICT_WII :
WMASK_AUDIO_HI_RESTRICT_GCN); WMASK_AUDIO_HI_RESTRICT_GCN);
})); }));
// Audio DMA MMIO controlling the DMA start. // Audio DMA MMIO controlling the DMA start.
mmio->Register( mmio->Register(
base | AUDIO_DMA_CONTROL_LEN, MMIO::DirectRead<u16>(&state.audio_dma.AudioDMAControl.Hex), base | AUDIO_DMA_CONTROL_LEN, MMIO::DirectRead<u16>(&m_audio_dma.AudioDMAControl.Hex),
MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) { MMIO::ComplexWrite<u16>([](Core::System& system, u32, u16 val) {
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
bool already_enabled = state_.audio_dma.AudioDMAControl.Enable; bool already_enabled = dsp.m_audio_dma.AudioDMAControl.Enable;
state_.audio_dma.AudioDMAControl.Hex = val; dsp.m_audio_dma.AudioDMAControl.Hex = val;
// Only load new values if we're not already doing a DMA transfer, // Only load new values if we're not already doing a DMA transfer,
// otherwise just let the new values be autoloaded in when the // otherwise just let the new values be autoloaded in when the
// current transfer ends. // current transfer ends.
if (!already_enabled && state_.audio_dma.AudioDMAControl.Enable) if (!already_enabled && dsp.m_audio_dma.AudioDMAControl.Enable)
{ {
state_.audio_dma.current_source_address = state_.audio_dma.SourceAddress; dsp.m_audio_dma.current_source_address = dsp.m_audio_dma.SourceAddress;
state_.audio_dma.remaining_blocks_count = state_.audio_dma.AudioDMAControl.NumBlocks; dsp.m_audio_dma.remaining_blocks_count = dsp.m_audio_dma.AudioDMAControl.NumBlocks;
INFO_LOG_FMT(AUDIO_INTERFACE, "Audio DMA configured: {} blocks from {:#010x}", INFO_LOG_FMT(AUDIO_INTERFACE, "Audio DMA configured: {} blocks from {:#010x}",
state_.audio_dma.AudioDMAControl.NumBlocks, state_.audio_dma.SourceAddress); dsp.m_audio_dma.AudioDMAControl.NumBlocks, dsp.m_audio_dma.SourceAddress);
// TODO: need hardware tests for the timing of this interrupt. // TODO: need hardware tests for the timing of this interrupt.
// Sky Crawlers crashes at boot if this is scheduled less than 87 cycles in the future. // Sky Crawlers crashes at boot if this is scheduled less than 87 cycles in the future.
// Other Namco games crash too, see issue 9509. For now we will just push it to 200 cycles // Other Namco games crash too, see issue 9509. For now we will just push it to 200 cycles
system.GetCoreTiming().ScheduleEvent(200, state_.event_type_generate_dsp_interrupt, system.GetCoreTiming().ScheduleEvent(200, dsp.m_event_type_generate_dsp_interrupt,
INT_AID); INT_AID);
} }
})); }));
@ -447,9 +354,9 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base)
MMIO::ComplexRead<u16>([](Core::System& system, u32) { MMIO::ComplexRead<u16>([](Core::System& system, u32) {
// remaining_blocks_count is zero-based. DreamMix World Fighters will hang if it // remaining_blocks_count is zero-based. DreamMix World Fighters will hang if it
// never reaches zero. // never reaches zero.
auto& state_ = system.GetDSPState().GetData(); auto& dsp = system.GetDSP();
return (state_.audio_dma.remaining_blocks_count > 0 ? return (dsp.m_audio_dma.remaining_blocks_count > 0 ?
state_.audio_dma.remaining_blocks_count - 1 : dsp.m_audio_dma.remaining_blocks_count - 1 :
0); 0);
}), }),
MMIO::InvalidWrite<u16>()); MMIO::InvalidWrite<u16>());
@ -463,157 +370,148 @@ void RegisterMMIO(MMIO::Mapping* mmio, u32 base)
} }
// UpdateInterrupts // UpdateInterrupts
static void UpdateInterrupts() void DSPManager::UpdateInterrupts()
{ {
auto& system = Core::System::GetInstance();
auto& state = system.GetDSPState().GetData();
// For each interrupt bit in DSP_CONTROL, the interrupt enablemask is the bit directly // For each interrupt bit in DSP_CONTROL, the interrupt enablemask is the bit directly
// to the left of it. By doing: // to the left of it. By doing:
// (DSP_CONTROL>>1) & DSP_CONTROL & MASK_OF_ALL_INTERRUPT_BITS // (DSP_CONTROL>>1) & DSP_CONTROL & MASK_OF_ALL_INTERRUPT_BITS
// We can check if any of the interrupts are enabled and active, all at once. // We can check if any of the interrupts are enabled and active, all at once.
bool ints_set = (((state.dsp_control.Hex >> 1) & state.dsp_control.Hex & bool ints_set =
(INT_DSP | INT_ARAM | INT_AID)) != 0); (((m_dsp_control.Hex >> 1) & m_dsp_control.Hex & (INT_DSP | INT_ARAM | INT_AID)) != 0);
system.GetProcessorInterface().SetInterrupt(ProcessorInterface::INT_CAUSE_DSP, ints_set); m_system.GetProcessorInterface().SetInterrupt(ProcessorInterface::INT_CAUSE_DSP, ints_set);
} }
static void GenerateDSPInterrupt(Core::System& system, u64 DSPIntType, s64 cyclesLate) void DSPManager::GlobalGenerateDSPInterrupt(Core::System& system, u64 DSPIntType, s64 cyclesLate)
{ {
auto& state = system.GetDSPState().GetData(); system.GetDSP().GenerateDSPInterrupt(DSPIntType, cyclesLate);
}
void DSPManager::GenerateDSPInterrupt(u64 DSPIntType, s64 cyclesLate)
{
// The INT_* enumeration members have values that reflect their bit positions in // The INT_* enumeration members have values that reflect their bit positions in
// DSP_CONTROL - we mask by (INT_DSP | INT_ARAM | INT_AID) just to ensure people // DSP_CONTROL - we mask by (INT_DSP | INT_ARAM | INT_AID) just to ensure people
// don't call this with bogus values. // don't call this with bogus values.
state.dsp_control.Hex |= (DSPIntType & (INT_DSP | INT_ARAM | INT_AID)); m_dsp_control.Hex |= (DSPIntType & (INT_DSP | INT_ARAM | INT_AID));
UpdateInterrupts(); UpdateInterrupts();
} }
// CALLED FROM DSP EMULATOR, POSSIBLY THREADED // CALLED FROM DSP EMULATOR, POSSIBLY THREADED
void GenerateDSPInterruptFromDSPEmu(DSPInterruptType type, int cycles_into_future) void DSPManager::GenerateDSPInterruptFromDSPEmu(DSPInterruptType type, int cycles_into_future)
{ {
auto& system = Core::System::GetInstance(); auto& core_timing = m_system.GetCoreTiming();
auto& core_timing = system.GetCoreTiming(); core_timing.ScheduleEvent(cycles_into_future, m_event_type_generate_dsp_interrupt, type,
auto& state = system.GetDSPState().GetData();
core_timing.ScheduleEvent(cycles_into_future, state.event_type_generate_dsp_interrupt, type,
CoreTiming::FromThread::ANY); CoreTiming::FromThread::ANY);
} }
// called whenever SystemTimers thinks the DSP deserves a few more cycles // called whenever SystemTimers thinks the DSP deserves a few more cycles
void UpdateDSPSlice(int cycles) void DSPManager::UpdateDSPSlice(int cycles)
{ {
auto& state = Core::System::GetInstance().GetDSPState().GetData(); if (m_is_lle)
if (state.is_lle)
{ {
// use up the rest of the slice(if any) // use up the rest of the slice(if any)
state.dsp_emulator->DSP_Update(state.dsp_slice); m_dsp_emulator->DSP_Update(m_dsp_slice);
state.dsp_slice %= 6; m_dsp_slice %= 6;
// note the new budget // note the new budget
state.dsp_slice += cycles; m_dsp_slice += cycles;
} }
else else
{ {
state.dsp_emulator->DSP_Update(cycles); m_dsp_emulator->DSP_Update(cycles);
} }
} }
// This happens at 4 khz, since 32 bytes at 4khz = 4 bytes at 32 khz (16bit stereo pcm) // This happens at 4 khz, since 32 bytes at 4khz = 4 bytes at 32 khz (16bit stereo pcm)
void UpdateAudioDMA() void DSPManager::UpdateAudioDMA()
{ {
auto& system = Core::System::GetInstance();
auto& state = system.GetDSPState().GetData();
static short zero_samples[8 * 2] = {0}; static short zero_samples[8 * 2] = {0};
if (state.audio_dma.AudioDMAControl.Enable) if (m_audio_dma.AudioDMAControl.Enable)
{ {
// Read audio at g_audioDMA.current_source_address in RAM and push onto an // Read audio at g_audioDMA.current_source_address in RAM and push onto an
// external audio fifo in the emulator, to be mixed with the disc // external audio fifo in the emulator, to be mixed with the disc
// streaming output. // streaming output.
auto& memory = system.GetMemory(); auto& memory = m_system.GetMemory();
void* address = memory.GetPointer(state.audio_dma.current_source_address); void* address = memory.GetPointer(m_audio_dma.current_source_address);
AudioCommon::SendAIBuffer(system, reinterpret_cast<short*>(address), 8); AudioCommon::SendAIBuffer(m_system, reinterpret_cast<short*>(address), 8);
if (state.audio_dma.remaining_blocks_count != 0) if (m_audio_dma.remaining_blocks_count != 0)
{ {
state.audio_dma.remaining_blocks_count--; m_audio_dma.remaining_blocks_count--;
state.audio_dma.current_source_address += 32; m_audio_dma.current_source_address += 32;
} }
if (state.audio_dma.remaining_blocks_count == 0) if (m_audio_dma.remaining_blocks_count == 0)
{ {
state.audio_dma.current_source_address = state.audio_dma.SourceAddress; m_audio_dma.current_source_address = m_audio_dma.SourceAddress;
state.audio_dma.remaining_blocks_count = state.audio_dma.AudioDMAControl.NumBlocks; m_audio_dma.remaining_blocks_count = m_audio_dma.AudioDMAControl.NumBlocks;
GenerateDSPInterrupt(system, DSP::INT_AID); GenerateDSPInterrupt(DSP::INT_AID, 0);
} }
} }
else else
{ {
AudioCommon::SendAIBuffer(system, &zero_samples[0], 8); AudioCommon::SendAIBuffer(m_system, &zero_samples[0], 8);
} }
} }
static void Do_ARAM_DMA() void DSPManager::Do_ARAM_DMA()
{ {
auto& system = Core::System::GetInstance(); auto& core_timing = m_system.GetCoreTiming();
auto& core_timing = system.GetCoreTiming(); auto& memory = m_system.GetMemory();
auto& memory = system.GetMemory();
auto& state = system.GetDSPState().GetData();
state.dsp_control.DMAState = 1; m_dsp_control.DMAState = 1;
// ARAM DMA transfer rate has been measured on real hw // ARAM DMA transfer rate has been measured on real hw
int ticksToTransfer = (state.aram_dma.Cnt.count / 32) * 246; int ticksToTransfer = (m_aram_dma.Cnt.count / 32) * 246;
core_timing.ScheduleEvent(ticksToTransfer, state.event_type_complete_aram); core_timing.ScheduleEvent(ticksToTransfer, m_event_type_complete_aram);
// Real hardware DMAs in 32byte chunks, but we can get by with 8byte chunks // Real hardware DMAs in 32byte chunks, but we can get by with 8byte chunks
if (state.aram_dma.Cnt.dir) if (m_aram_dma.Cnt.dir)
{ {
// ARAM -> MRAM // ARAM -> MRAM
DEBUG_LOG_FMT(DSPINTERFACE, "DMA {:08x} bytes from ARAM {:08x} to MRAM {:08x} PC: {:08x}", DEBUG_LOG_FMT(DSPINTERFACE, "DMA {:08x} bytes from ARAM {:08x} to MRAM {:08x} PC: {:08x}",
state.aram_dma.Cnt.count, state.aram_dma.ARAddr, state.aram_dma.MMAddr, m_aram_dma.Cnt.count, m_aram_dma.ARAddr, m_aram_dma.MMAddr,
system.GetPPCState().pc); m_system.GetPPCState().pc);
// Outgoing data from ARAM is mirrored every 64MB (verified on real HW) // Outgoing data from ARAM is mirrored every 64MB (verified on real HW)
state.aram_dma.ARAddr &= 0x3ffffff; m_aram_dma.ARAddr &= 0x3ffffff;
state.aram_dma.MMAddr &= 0x3ffffff; m_aram_dma.MMAddr &= 0x3ffffff;
if (state.aram_dma.ARAddr < state.aram.size) if (m_aram_dma.ARAddr < m_aram.size)
{ {
while (state.aram_dma.Cnt.count) while (m_aram_dma.Cnt.count)
{ {
// These are logically separated in code to show that a memory map has been set up // These are logically separated in code to show that a memory map has been set up
// See below in the write section for more information // See below in the write section for more information
if ((state.aram_info.Hex & 0xf) == 3) if ((m_aram_info.Hex & 0xf) == 3)
{ {
memory.Write_U64_Swap(*(u64*)&state.aram.ptr[state.aram_dma.ARAddr & state.aram.mask], memory.Write_U64_Swap(*(u64*)&m_aram.ptr[m_aram_dma.ARAddr & m_aram.mask],
state.aram_dma.MMAddr); m_aram_dma.MMAddr);
} }
else if ((state.aram_info.Hex & 0xf) == 4) else if ((m_aram_info.Hex & 0xf) == 4)
{ {
memory.Write_U64_Swap(*(u64*)&state.aram.ptr[state.aram_dma.ARAddr & state.aram.mask], memory.Write_U64_Swap(*(u64*)&m_aram.ptr[m_aram_dma.ARAddr & m_aram.mask],
state.aram_dma.MMAddr); m_aram_dma.MMAddr);
} }
else else
{ {
memory.Write_U64_Swap(*(u64*)&state.aram.ptr[state.aram_dma.ARAddr & state.aram.mask], memory.Write_U64_Swap(*(u64*)&m_aram.ptr[m_aram_dma.ARAddr & m_aram.mask],
state.aram_dma.MMAddr); m_aram_dma.MMAddr);
} }
state.aram_dma.MMAddr += 8; m_aram_dma.MMAddr += 8;
state.aram_dma.ARAddr += 8; m_aram_dma.ARAddr += 8;
state.aram_dma.Cnt.count -= 8; m_aram_dma.Cnt.count -= 8;
} }
} }
else if (!state.aram.wii_mode) else if (!m_aram.wii_mode)
{ {
while (state.aram_dma.Cnt.count) while (m_aram_dma.Cnt.count)
{ {
memory.Write_U64(system.GetHSP().Read(state.aram_dma.ARAddr), state.aram_dma.MMAddr); memory.Write_U64(m_system.GetHSP().Read(m_aram_dma.ARAddr), m_aram_dma.MMAddr);
state.aram_dma.MMAddr += 8; m_aram_dma.MMAddr += 8;
state.aram_dma.ARAddr += 8; m_aram_dma.ARAddr += 8;
state.aram_dma.Cnt.count -= 8; m_aram_dma.Cnt.count -= 8;
} }
} }
} }
@ -621,52 +519,52 @@ static void Do_ARAM_DMA()
{ {
// MRAM -> ARAM // MRAM -> ARAM
DEBUG_LOG_FMT(DSPINTERFACE, "DMA {:08x} bytes from MRAM {:08x} to ARAM {:08x} PC: {:08x}", DEBUG_LOG_FMT(DSPINTERFACE, "DMA {:08x} bytes from MRAM {:08x} to ARAM {:08x} PC: {:08x}",
state.aram_dma.Cnt.count, state.aram_dma.MMAddr, state.aram_dma.ARAddr, m_aram_dma.Cnt.count, m_aram_dma.MMAddr, m_aram_dma.ARAddr,
system.GetPPCState().pc); m_system.GetPPCState().pc);
// Incoming data into ARAM is mirrored every 64MB (verified on real HW) // Incoming data into ARAM is mirrored every 64MB (verified on real HW)
state.aram_dma.ARAddr &= 0x3ffffff; m_aram_dma.ARAddr &= 0x3ffffff;
state.aram_dma.MMAddr &= 0x3ffffff; m_aram_dma.MMAddr &= 0x3ffffff;
if (state.aram_dma.ARAddr < state.aram.size) if (m_aram_dma.ARAddr < m_aram.size)
{ {
while (state.aram_dma.Cnt.count) while (m_aram_dma.Cnt.count)
{ {
if ((state.aram_info.Hex & 0xf) == 3) if ((m_aram_info.Hex & 0xf) == 3)
{ {
*(u64*)&state.aram.ptr[state.aram_dma.ARAddr & state.aram.mask] = *(u64*)&m_aram.ptr[m_aram_dma.ARAddr & m_aram.mask] =
Common::swap64(memory.Read_U64(state.aram_dma.MMAddr)); Common::swap64(memory.Read_U64(m_aram_dma.MMAddr));
} }
else if ((state.aram_info.Hex & 0xf) == 4) else if ((m_aram_info.Hex & 0xf) == 4)
{ {
if (state.aram_dma.ARAddr < 0x400000) if (m_aram_dma.ARAddr < 0x400000)
{ {
*(u64*)&state.aram.ptr[(state.aram_dma.ARAddr + 0x400000) & state.aram.mask] = *(u64*)&m_aram.ptr[(m_aram_dma.ARAddr + 0x400000) & m_aram.mask] =
Common::swap64(memory.Read_U64(state.aram_dma.MMAddr)); Common::swap64(memory.Read_U64(m_aram_dma.MMAddr));
} }
*(u64*)&state.aram.ptr[state.aram_dma.ARAddr & state.aram.mask] = *(u64*)&m_aram.ptr[m_aram_dma.ARAddr & m_aram.mask] =
Common::swap64(memory.Read_U64(state.aram_dma.MMAddr)); Common::swap64(memory.Read_U64(m_aram_dma.MMAddr));
} }
else else
{ {
*(u64*)&state.aram.ptr[state.aram_dma.ARAddr & state.aram.mask] = *(u64*)&m_aram.ptr[m_aram_dma.ARAddr & m_aram.mask] =
Common::swap64(memory.Read_U64(state.aram_dma.MMAddr)); Common::swap64(memory.Read_U64(m_aram_dma.MMAddr));
} }
state.aram_dma.MMAddr += 8; m_aram_dma.MMAddr += 8;
state.aram_dma.ARAddr += 8; m_aram_dma.ARAddr += 8;
state.aram_dma.Cnt.count -= 8; m_aram_dma.Cnt.count -= 8;
} }
} }
else if (!state.aram.wii_mode) else if (!m_aram.wii_mode)
{ {
while (state.aram_dma.Cnt.count) while (m_aram_dma.Cnt.count)
{ {
system.GetHSP().Write(state.aram_dma.ARAddr, memory.Read_U64(state.aram_dma.MMAddr)); m_system.GetHSP().Write(m_aram_dma.ARAddr, memory.Read_U64(m_aram_dma.MMAddr));
state.aram_dma.MMAddr += 8; m_aram_dma.MMAddr += 8;
state.aram_dma.ARAddr += 8; m_aram_dma.ARAddr += 8;
state.aram_dma.Cnt.count -= 8; m_aram_dma.Cnt.count -= 8;
} }
} }
} }
@ -675,41 +573,35 @@ static void Do_ARAM_DMA()
// (shuffle2) I still don't believe that this hack is actually needed... :( // (shuffle2) I still don't believe that this hack is actually needed... :(
// Maybe the Wii Sports ucode is processed incorrectly? // Maybe the Wii Sports ucode is processed incorrectly?
// (LM) It just means that DSP reads via '0xffdd' on Wii can end up in EXRAM or main RAM // (LM) It just means that DSP reads via '0xffdd' on Wii can end up in EXRAM or main RAM
u8 ReadARAM(u32 address) u8 DSPManager::ReadARAM(u32 address) const
{ {
auto& system = Core::System::GetInstance(); if (m_aram.wii_mode)
auto& state = system.GetDSPState().GetData();
if (state.aram.wii_mode)
{ {
if (address & 0x10000000) if (address & 0x10000000)
{ {
return state.aram.ptr[address & state.aram.mask]; return m_aram.ptr[address & m_aram.mask];
} }
else else
{ {
auto& memory = system.GetMemory(); auto& memory = m_system.GetMemory();
return memory.Read_U8(address & memory.GetRamMask()); return memory.Read_U8(address & memory.GetRamMask());
} }
} }
else else
{ {
return state.aram.ptr[address & state.aram.mask]; return m_aram.ptr[address & m_aram.mask];
} }
} }
void WriteARAM(u8 value, u32 address) void DSPManager::WriteARAM(u8 value, u32 address)
{ {
auto& state = Core::System::GetInstance().GetDSPState().GetData();
// TODO: verify this on Wii // TODO: verify this on Wii
state.aram.ptr[address & state.aram.mask] = value; m_aram.ptr[address & m_aram.mask] = value;
} }
u8* GetARAMPtr() u8* DSPManager::GetARAMPtr() const
{ {
auto& state = Core::System::GetInstance().GetDSPState().GetData(); return m_aram.ptr;
return state.aram.ptr;
} }
} // end of namespace DSP } // end of namespace DSP

153
Source/Core/Core/HW/DSP.h
View File

@ -9,6 +9,14 @@
class PointerWrap; class PointerWrap;
class DSPEmulator; class DSPEmulator;
namespace Core
{
class System;
}
namespace CoreTiming
{
struct EventType;
}
namespace MMIO namespace MMIO
{ {
class Mapping; class Mapping;
@ -16,23 +24,6 @@ class Mapping;
namespace DSP namespace DSP
{ {
class DSPState
{
public:
DSPState();
DSPState(const DSPState&) = delete;
DSPState(DSPState&&) = delete;
DSPState& operator=(const DSPState&) = delete;
DSPState& operator=(DSPState&&) = delete;
~DSPState();
struct Data;
Data& GetData() { return *m_data; }
private:
std::unique_ptr<Data> m_data;
};
enum DSPInterruptType enum DSPInterruptType
{ {
INT_DSP = 0x80, INT_DSP = 0x80,
@ -77,27 +68,125 @@ union UDSPControl
UDSPControl(u16 hex = 0) : Hex(hex) {} UDSPControl(u16 hex = 0) : Hex(hex) {}
}; };
void Init(bool hle); class DSPManager
void Reinit(bool hle); {
void Shutdown(); public:
explicit DSPManager(Core::System& system);
DSPManager(const DSPManager&) = delete;
DSPManager(DSPManager&&) = delete;
DSPManager& operator=(const DSPManager&) = delete;
DSPManager& operator=(DSPManager&&) = delete;
~DSPManager();
void RegisterMMIO(MMIO::Mapping* mmio, u32 base); void Init(bool hle);
void Reinit(bool hle);
void Shutdown();
DSPEmulator* GetDSPEmulator(); void RegisterMMIO(MMIO::Mapping* mmio, u32 base);
void DoState(PointerWrap& p); DSPEmulator* GetDSPEmulator();
// TODO: Maybe rethink this? The timing is unpredictable. void DoState(PointerWrap& p);
void GenerateDSPInterruptFromDSPEmu(DSPInterruptType type, int cycles_into_future = 0);
// Audio/DSP Helper // TODO: Maybe rethink this? The timing is unpredictable.
u8 ReadARAM(u32 address); void GenerateDSPInterruptFromDSPEmu(DSPInterruptType type, int cycles_into_future = 0);
void WriteARAM(u8 value, u32 address);
// Debugger Helper // Audio/DSP Helper
u8* GetARAMPtr(); u8 ReadARAM(u32 address) const;
void WriteARAM(u8 value, u32 address);
void UpdateAudioDMA(); // Debugger Helper
void UpdateDSPSlice(int cycles); u8* GetARAMPtr() const;
void UpdateAudioDMA();
void UpdateDSPSlice(int cycles);
private:
void GenerateDSPInterrupt(u64 DSPIntType, s64 cyclesLate);
static void GlobalGenerateDSPInterrupt(Core::System& system, u64 DSPIntType, s64 cyclesLate);
void CompleteARAM(u64 userdata, s64 cyclesLate);
static void GlobalCompleteARAM(Core::System& system, u64 userdata, s64 cyclesLate);
void UpdateInterrupts();
void Do_ARAM_DMA();
// UARAMCount
union UARAMCount
{
u32 Hex = 0;
struct
{
u32 count : 31;
u32 dir : 1; // 0: MRAM -> ARAM 1: ARAM -> MRAM
};
};
// Blocks are 32 bytes.
union UAudioDMAControl
{
u16 Hex = 0;
struct
{
u16 NumBlocks : 15;
u16 Enable : 1;
};
};
// AudioDMA
struct AudioDMA
{
u32 current_source_address = 0;
u16 remaining_blocks_count = 0;
u32 SourceAddress = 0;
UAudioDMAControl AudioDMAControl;
};
// ARAM_DMA
struct ARAM_DMA
{
u32 MMAddr = 0;
u32 ARAddr = 0;
UARAMCount Cnt;
};
// So we may abstract GC/Wii differences a little
struct ARAMInfo
{
bool wii_mode = false; // Wii EXRAM is managed in Memory:: so we need to skip statesaving, etc
u32 size = ARAM_SIZE;
u32 mask = ARAM_MASK;
u8* ptr = nullptr; // aka audio ram, auxiliary ram, MEM2, EXRAM, etc...
};
union ARAM_Info
{
u16 Hex = 0;
struct
{
u16 size : 6;
u16 unk : 1;
u16 : 9;
};
};
ARAMInfo m_aram;
AudioDMA m_audio_dma;
ARAM_DMA m_aram_dma;
UDSPControl m_dsp_control;
ARAM_Info m_aram_info;
// Contains bitfields for some stuff we don't care about (and nothing ever reads):
// CAS latency/burst length/addressing mode/write mode
// We care about the LSB tho. It indicates that the ARAM controller has finished initializing
u16 m_aram_mode = 0;
u16 m_aram_refresh = 0;
int m_dsp_slice = 0;
std::unique_ptr<DSPEmulator> m_dsp_emulator;
bool m_is_lle = false;
CoreTiming::EventType* m_event_type_generate_dsp_interrupt = nullptr;
CoreTiming::EventType* m_event_type_complete_aram = nullptr;
Core::System& m_system;
};
} // namespace DSP } // namespace DSP

6
Source/Core/Core/HW/DSPHLE/MailHandler.cpp
View File

@ -8,6 +8,7 @@
#include "Common/Logging/Log.h" #include "Common/Logging/Log.h"
#include "Common/MsgHandler.h" #include "Common/MsgHandler.h"
#include "Core/HW/DSP.h" #include "Core/HW/DSP.h"
#include "Core/System.h"
namespace DSP::HLE namespace DSP::HLE
{ {
@ -25,7 +26,8 @@ void CMailHandler::PushMail(u32 mail, bool interrupt, int cycles_into_future)
{ {
if (m_pending_mails.empty()) if (m_pending_mails.empty())
{ {
DSP::GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP, cycles_into_future); Core::System::GetInstance().GetDSP().GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP,
cycles_into_future);
} }
else else
{ {
@ -58,7 +60,7 @@ u16 CMailHandler::ReadDSPMailboxLow()
if (generate_interrupt) if (generate_interrupt)
{ {
DSP::GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP); Core::System::GetInstance().GetDSP().GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP);
} }
} }
// Clear the top bit of the high mail word after the mail has been read. // Clear the top bit of the high mail word after the mail has been read.

13
Source/Core/Core/HW/DSPHLE/UCodes/AESnd.cpp
View File

@ -16,6 +16,7 @@
#include "Core/HW/DSPHLE/DSPHLE.h" #include "Core/HW/DSPHLE/DSPHLE.h"
#include "Core/HW/DSPHLE/MailHandler.h" #include "Core/HW/DSPHLE/MailHandler.h"
#include "Core/HW/DSPHLE/UCodes/UCodes.h" #include "Core/HW/DSPHLE/UCodes/UCodes.h"
#include "Core/System.h"
namespace DSP::HLE namespace DSP::HLE
{ {
@ -94,7 +95,7 @@ void AESndUCode::Update()
// This is dubious in general, since we set the interrupt parameter on m_mail_handler.PushMail // This is dubious in general, since we set the interrupt parameter on m_mail_handler.PushMail
if (m_mail_handler.HasPending()) if (m_mail_handler.HasPending())
{ {
DSP::GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP); Core::System::GetInstance().GetDSP().GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP);
} }
} }
@ -246,8 +247,14 @@ protected:
SetPredScale(GetPredScale()); SetPredScale(GetPredScale());
} }
u8 ReadMemory(u32 address) override { return ReadARAM(address); } u8 ReadMemory(u32 address) override
void WriteMemory(u32 address, u8 value) override { WriteARAM(value, address); } {
return Core::System::GetInstance().GetDSP().ReadARAM(address);
}
void WriteMemory(u32 address, u8 value) override
{
Core::System::GetInstance().GetDSP().WriteARAM(value, address);
}
}; };
static std::unique_ptr<Accelerator> s_accelerator = std::make_unique<AESndAccelerator>(); static std::unique_ptr<Accelerator> s_accelerator = std::make_unique<AESndAccelerator>();

3
Source/Core/Core/HW/DSPHLE/UCodes/ASnd.cpp
View File

@ -15,6 +15,7 @@
#include "Core/HW/DSPHLE/DSPHLE.h" #include "Core/HW/DSPHLE/DSPHLE.h"
#include "Core/HW/DSPHLE/MailHandler.h" #include "Core/HW/DSPHLE/MailHandler.h"
#include "Core/HW/DSPHLE/UCodes/UCodes.h" #include "Core/HW/DSPHLE/UCodes/UCodes.h"
#include "Core/System.h"
namespace DSP::HLE namespace DSP::HLE
{ {
@ -79,7 +80,7 @@ void ASndUCode::Update()
// This is dubious in general, since we set the interrupt parameter on m_mail_handler.PushMail // This is dubious in general, since we set the interrupt parameter on m_mail_handler.PushMail
if (m_mail_handler.HasPending()) if (m_mail_handler.HasPending())
{ {
DSP::GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP); Core::System::GetInstance().GetDSP().GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP);
} }
} }

10
Source/Core/Core/HW/DSPHLE/UCodes/AXVoice.h
View File

@ -187,8 +187,14 @@ protected:
} }
} }
u8 ReadMemory(u32 address) override { return ReadARAM(address); } u8 ReadMemory(u32 address) override
void WriteMemory(u32 address, u8 value) override { WriteARAM(value, address); } {
return Core::System::GetInstance().GetDSP().ReadARAM(address);
}
void WriteMemory(u32 address, u8 value) override
{
Core::System::GetInstance().GetDSP().WriteARAM(value, address);
}
}; };
static std::unique_ptr<Accelerator> s_accelerator = std::make_unique<HLEAccelerator>(); static std::unique_ptr<Accelerator> s_accelerator = std::make_unique<HLEAccelerator>();

3
Source/Core/Core/HW/DSPHLE/UCodes/CARD.cpp
View File

@ -9,6 +9,7 @@
#include "Core/HW/DSP.h" #include "Core/HW/DSP.h"
#include "Core/HW/DSPHLE/DSPHLE.h" #include "Core/HW/DSPHLE/DSPHLE.h"
#include "Core/HW/DSPHLE/UCodes/UCodes.h" #include "Core/HW/DSPHLE/UCodes/UCodes.h"
#include "Core/System.h"
namespace DSP::HLE namespace DSP::HLE
{ {
@ -27,7 +28,7 @@ void CARDUCode::Update()
// check if we have something to send // check if we have something to send
if (m_mail_handler.HasPending()) if (m_mail_handler.HasPending())
{ {
DSP::GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP); Core::System::GetInstance().GetDSP().GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP);
} }
} }

3
Source/Core/Core/HW/DSPHLE/UCodes/GBA.cpp
View File

@ -11,6 +11,7 @@
#include "Core/HW/DSPHLE/DSPHLE.h" #include "Core/HW/DSPHLE/DSPHLE.h"
#include "Core/HW/DSPHLE/MailHandler.h" #include "Core/HW/DSPHLE/MailHandler.h"
#include "Core/HW/DSPHLE/UCodes/UCodes.h" #include "Core/HW/DSPHLE/UCodes/UCodes.h"
#include "Core/System.h"
namespace DSP::HLE namespace DSP::HLE
{ {
@ -84,7 +85,7 @@ void GBAUCode::Update()
// check if we have something to send // check if we have something to send
if (m_mail_handler.HasPending()) if (m_mail_handler.HasPending())
{ {
DSP::GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP); Core::System::GetInstance().GetDSP().GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP);
} }
} }

5
Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp
View File

@ -16,6 +16,7 @@
#include "Core/HW/DSPHLE/MailHandler.h" #include "Core/HW/DSPHLE/MailHandler.h"
#include "Core/HW/DSPHLE/UCodes/GBA.h" #include "Core/HW/DSPHLE/UCodes/GBA.h"
#include "Core/HW/DSPHLE/UCodes/UCodes.h" #include "Core/HW/DSPHLE/UCodes/UCodes.h"
#include "Core/System.h"
namespace DSP::HLE namespace DSP::HLE
{ {
@ -367,7 +368,7 @@ void ZeldaUCode::HandleMailLight(u32 mail)
m_sync_max_voice_id = 0xFFFFFFFF; m_sync_max_voice_id = 0xFFFFFFFF;
m_sync_voice_skip_flags.fill(0xFFFF); m_sync_voice_skip_flags.fill(0xFFFF);
RenderAudio(); RenderAudio();
DSP::GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP); Core::System::GetInstance().GetDSP().GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP);
break; break;
case MailState::HALTED: case MailState::HALTED:
@ -1542,7 +1543,7 @@ void* ZeldaAudioRenderer::GetARAMPtr() const
if (m_aram_base_addr) if (m_aram_base_addr)
return HLEMemory_Get_Pointer(m_aram_base_addr); return HLEMemory_Get_Pointer(m_aram_base_addr);
else else
return DSP::GetARAMPtr(); return Core::System::GetInstance().GetDSP().GetARAMPtr();
} }
template <typename T> template <typename T>

6
Source/Core/Core/HW/DSPLLE/DSPHost.cpp
View File

@ -30,12 +30,12 @@ namespace DSP::Host
{ {
u8 ReadHostMemory(u32 addr) u8 ReadHostMemory(u32 addr)
{ {
return DSP::ReadARAM(addr); return Core::System::GetInstance().GetDSP().ReadARAM(addr);
} }
void WriteHostMemory(u8 value, u32 addr) void WriteHostMemory(u8 value, u32 addr)
{ {
DSP::WriteARAM(value, addr); Core::System::GetInstance().GetDSP().WriteARAM(value, addr);
} }
void DMAToDSP(u16* dst, u32 addr, u32 size) void DMAToDSP(u16* dst, u32 addr, u32 size)
@ -70,7 +70,7 @@ bool IsWiiHost()
void InterruptRequest() void InterruptRequest()
{ {
// Fire an interrupt on the PPC ASAP. // Fire an interrupt on the PPC ASAP.
DSP::GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP); Core::System::GetInstance().GetDSP().GenerateDSPInterruptFromDSPEmu(DSP::INT_DSP);
} }
void CodeLoaded(DSPCore& dsp, u32 addr, size_t size) void CodeLoaded(DSPCore& dsp, u32 addr, size_t size)

6
Source/Core/Core/HW/HW.cpp
View File

@ -49,7 +49,7 @@ void Init(const Sram* override_sram)
system.GetMemory().Init(); // Needs to be initialized before AddressSpace system.GetMemory().Init(); // Needs to be initialized before AddressSpace
AddressSpace::Init(); AddressSpace::Init();
MemoryInterface::Init(); MemoryInterface::Init();
DSP::Init(Config::Get(Config::MAIN_DSP_HLE)); system.GetDSP().Init(Config::Get(Config::MAIN_DSP_HLE));
DVDInterface::Init(); DVDInterface::Init();
system.GetGPFifo().Init(); system.GetGPFifo().Init();
system.GetCPU().Init(Config::Get(Config::MAIN_CPU_CORE)); system.GetCPU().Init(Config::Get(Config::MAIN_CPU_CORE));
@ -73,7 +73,7 @@ void Shutdown()
SystemTimers::Shutdown(); SystemTimers::Shutdown();
system.GetCPU().Shutdown(); system.GetCPU().Shutdown();
DVDInterface::Shutdown(); DVDInterface::Shutdown();
DSP::Shutdown(); system.GetDSP().Shutdown();
MemoryInterface::Shutdown(); MemoryInterface::Shutdown();
AddressSpace::Shutdown(); AddressSpace::Shutdown();
system.GetMemory().Shutdown(); system.GetMemory().Shutdown();
@ -99,7 +99,7 @@ void DoState(PointerWrap& p)
p.DoMarker("SerialInterface"); p.DoMarker("SerialInterface");
system.GetProcessorInterface().DoState(p); system.GetProcessorInterface().DoState(p);
p.DoMarker("ProcessorInterface"); p.DoMarker("ProcessorInterface");
DSP::DoState(p); system.GetDSP().DoState(p);
p.DoMarker("DSP"); p.DoMarker("DSP");
DVDInterface::DoState(p); DVDInterface::DoState(p);
p.DoMarker("DVDInterface"); p.DoMarker("DVDInterface");

2
Source/Core/Core/HW/Memmap.cpp
View File

@ -54,7 +54,7 @@ void MemoryManager::InitMMIO(bool is_wii)
VideoInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C002000); VideoInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C002000);
system.GetProcessorInterface().RegisterMMIO(m_mmio_mapping.get(), 0x0C003000); system.GetProcessorInterface().RegisterMMIO(m_mmio_mapping.get(), 0x0C003000);
MemoryInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C004000); MemoryInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C004000);
DSP::RegisterMMIO(m_mmio_mapping.get(), 0x0C005000); system.GetDSP().RegisterMMIO(m_mmio_mapping.get(), 0x0C005000);
DVDInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C006000, false); DVDInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C006000, false);
SerialInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C006400); SerialInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C006400);
ExpansionInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C006800); ExpansionInterface::RegisterMMIO(m_mmio_mapping.get(), 0x0C006800);

8
Source/Core/Core/HW/SystemTimers.cpp
View File

@ -97,9 +97,9 @@ void DSPCallback(Core::System& system, u64 userdata, s64 cyclesLate)
{ {
// splits up the cycle budget in case lle is used // splits up the cycle budget in case lle is used
// for hle, just gives all of the slice to hle // for hle, just gives all of the slice to hle
DSP::UpdateDSPSlice(static_cast<int>(DSP::GetDSPEmulator()->DSP_UpdateRate() - cyclesLate)); auto& dsp = system.GetDSP();
system.GetCoreTiming().ScheduleEvent(DSP::GetDSPEmulator()->DSP_UpdateRate() - cyclesLate, dsp.UpdateDSPSlice(static_cast<int>(dsp.GetDSPEmulator()->DSP_UpdateRate() - cyclesLate));
et_DSP); system.GetCoreTiming().ScheduleEvent(dsp.GetDSPEmulator()->DSP_UpdateRate() - cyclesLate, et_DSP);
} }
int GetAudioDMACallbackPeriod() int GetAudioDMACallbackPeriod()
@ -112,7 +112,7 @@ int GetAudioDMACallbackPeriod()
void AudioDMACallback(Core::System& system, u64 userdata, s64 cyclesLate) void AudioDMACallback(Core::System& system, u64 userdata, s64 cyclesLate)
{ {
DSP::UpdateAudioDMA(); // Push audio to speakers. system.GetDSP().UpdateAudioDMA(); // Push audio to speakers.
system.GetCoreTiming().ScheduleEvent(GetAudioDMACallbackPeriod() - cyclesLate, et_AudioDMA); system.GetCoreTiming().ScheduleEvent(GetAudioDMACallbackPeriod() - cyclesLate, et_AudioDMA);
} }

7
Source/Core/Core/IOS/MIOS.cpp
View File

@ -46,9 +46,10 @@ static void ReinitHardware()
PowerPC::Reset(); PowerPC::Reset();
Wiimote::ResetAllWiimotes(); Wiimote::ResetAllWiimotes();
// Note: this is specific to Dolphin and is required because we initialised it in Wii mode. // Note: this is specific to Dolphin and is required because we initialised it in Wii mode.
DSP::Reinit(Config::Get(Config::MAIN_DSP_HLE)); auto& dsp = system.GetDSP();
DSP::GetDSPEmulator()->Initialize(SConfig::GetInstance().bWii, dsp.Reinit(Config::Get(Config::MAIN_DSP_HLE));
Config::Get(Config::MAIN_DSP_THREAD)); dsp.GetDSPEmulator()->Initialize(SConfig::GetInstance().bWii,
Config::Get(Config::MAIN_DSP_THREAD));
SystemTimers::ChangePPCClock(SystemTimers::Mode::GC); SystemTimers::ChangePPCClock(SystemTimers::Mode::GC);
} }

8
Source/Core/Core/System.cpp
View File

@ -36,7 +36,7 @@ namespace Core
struct System::Impl struct System::Impl
{ {
explicit Impl(System& system) explicit Impl(System& system)
: m_audio_interface(system), m_core_timing(system), m_gp_fifo(system), : m_audio_interface(system), m_core_timing(system), m_dsp(system), m_gp_fifo(system),
m_ppc_state(PowerPC::ppcState) m_ppc_state(PowerPC::ppcState)
{ {
} }
@ -49,7 +49,7 @@ struct System::Impl
CoreTiming::CoreTimingManager m_core_timing; CoreTiming::CoreTimingManager m_core_timing;
CommandProcessor::CommandProcessorManager m_command_processor; CommandProcessor::CommandProcessorManager m_command_processor;
CPU::CPUManager m_cpu; CPU::CPUManager m_cpu;
DSP::DSPState m_dsp_state; DSP::DSPManager m_dsp;
DVDInterface::DVDInterfaceState m_dvd_interface_state; DVDInterface::DVDInterfaceState m_dvd_interface_state;
DVDThread::DVDThreadState m_dvd_thread_state; DVDThread::DVDThreadState m_dvd_thread_state;
ExpansionInterface::ExpansionInterfaceState m_expansion_interface_state; ExpansionInterface::ExpansionInterfaceState m_expansion_interface_state;
@ -133,9 +133,9 @@ CommandProcessor::CommandProcessorManager& System::GetCommandProcessor() const
return m_impl->m_command_processor; return m_impl->m_command_processor;
} }
DSP::DSPState& System::GetDSPState() const DSP::DSPManager& System::GetDSP() const
{ {
return m_impl->m_dsp_state; return m_impl->m_dsp;
} }
DVDInterface::DVDInterfaceState& System::GetDVDInterfaceState() const DVDInterface::DVDInterfaceState& System::GetDVDInterfaceState() const

4
Source/Core/Core/System.h
View File

@ -29,7 +29,7 @@ class CoreTimingManager;
} }
namespace DSP namespace DSP
{ {
class DSPState; class DSPManager;
} }
namespace DVDInterface namespace DVDInterface
{ {
@ -126,7 +126,7 @@ public:
CPU::CPUManager& GetCPU() const; CPU::CPUManager& GetCPU() const;
CoreTiming::CoreTimingManager& GetCoreTiming() const; CoreTiming::CoreTimingManager& GetCoreTiming() const;
CommandProcessor::CommandProcessorManager& GetCommandProcessor() const; CommandProcessor::CommandProcessorManager& GetCommandProcessor() const;
DSP::DSPState& GetDSPState() const; DSP::DSPManager& GetDSP() const;
DVDInterface::DVDInterfaceState& GetDVDInterfaceState() const; DVDInterface::DVDInterfaceState& GetDVDInterfaceState() const;
DVDThread::DVDThreadState& GetDVDThreadState() const; DVDThread::DVDThreadState& GetDVDThreadState() const;
ExpansionInterface::ExpansionInterfaceState& GetExpansionInterfaceState() const; ExpansionInterface::ExpansionInterfaceState& GetExpansionInterfaceState() const;