piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-29 00:59:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

WiiSave: Clean up constructors

Browse Source 
Move the import/export operation into separate functions, as it doesn't
really make sense for the constructor to do *everything*, including
printing success/failure message boxes.

The existing constructor was split into two: one that takes a path,
and another taking a title ID. This makes it more obvious what is
actually done when a path/TID is passed and also clarifies what
parameters should be passed. (No more magic 0 or "" value.)
This commit is contained in:
Léo Lam
2018-05-13 00:05:08 +02:00
parent fbf36b85d2
commit 41c4486c65
6 changed files with 59 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/DolphinQt2/GameList/GameList.cpp
View File

@ -260,7 +260,7 @@ void GameList::ExportWiiSave()
{
QMessageBox result_dialog(this);
const bool success = WiiSave::ExportWiiSave(GetSelectedGame()->GetTitleID());
const bool success = WiiSave::Export(GetSelectedGame()->GetTitleID());
result_dialog.setIcon(success ? QMessageBox::Information : QMessageBox::Critical);
result_dialog.setText(success ? tr("Successfully exported save files") :

4
Source/Core/DolphinQt2/MenuBar.cpp
View File

@ -897,12 +897,12 @@ void MenuBar::ImportWiiSave()
"All Files (*)"));
if (!file.isEmpty())
WiiSave::ImportWiiSave(file.toStdString());
WiiSave::Import(file.toStdString());
}
void MenuBar::ExportWiiSaves()
{
WiiSave::ExportAllSaves();
WiiSave::ExportAll();
}
void MenuBar::CheckNAND()