From 4304f5f7fcae4ed1ec723ea83b4c0772e2f211f7 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Fri, 19 Jul 2019 19:42:42 +0200 Subject: [PATCH] Remove "not signed by Nintendo" warning when installing WADs Apparently nobody is using good dumps, meaning that the warning is a nuisance rather than useful information for most people. Especially so for people who don't install WADs permanently. It is still possible to verify the signature using the Verify tab of the game properties, which matches how Dolphin handles checking the signatures of Wii discs. --- Source/Core/Core/WiiUtils.cpp | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/Source/Core/Core/WiiUtils.cpp b/Source/Core/Core/WiiUtils.cpp index c8e8bf9b20..7318448430 100644 --- a/Source/Core/Core/WiiUtils.cpp +++ b/Source/Core/Core/WiiUtils.cpp @@ -59,7 +59,10 @@ static bool ImportWAD(IOS::HLE::Kernel& ios, const DiscIO::VolumeWAD& wad) IOS::HLE::Device::ES::Context context; IOS::HLE::ReturnCode ret; + + // A lot of people use fakesigned WADs, so disable signature checking temporarily when installing const bool checks_enabled = SConfig::GetInstance().m_enable_signature_checks; + SConfig::GetInstance().m_enable_signature_checks = false; IOS::ES::TicketReader ticket = wad.GetTicket(); // Ensure the common key index is correct, as it's checked by IOS. @@ -69,13 +72,6 @@ static bool ImportWAD(IOS::HLE::Kernel& ios, const DiscIO::VolumeWAD& wad) IOS::HLE::Device::ES::TicketImportType::Unpersonalised)) < 0 || (ret = es->ImportTitleInit(context, tmd.GetBytes(), wad.GetCertificateChain())) < 0) { - if (checks_enabled && ret == IOS::HLE::IOSC_FAIL_CHECKVALUE && - AskYesNoT("This WAD has not been signed by Nintendo. Continue to import?")) - { - SConfig::GetInstance().m_enable_signature_checks = false; - continue; - } - if (ret != IOS::HLE::IOSC_FAIL_CHECKVALUE) PanicAlertT("WAD installation failed: Could not initialise title import (error %d).", ret); SConfig::GetInstance().m_enable_signature_checks = checks_enabled;