From 4367e3aedaf59575a9da50898c8da951db32184d Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 21 Jun 2018 12:45:57 -0400 Subject: [PATCH] DSPIntExtOps: Make IsSameMemArea internally linked inline has external linkage, which doesn't really make sense here, given the function is only used within this translation unit. So we can replace inline with static. While we're at it, the code within the function can also be compressed to a single return statement. --- Source/Core/Core/DSP/Interpreter/DSPIntExtOps.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Source/Core/Core/DSP/Interpreter/DSPIntExtOps.cpp b/Source/Core/Core/DSP/Interpreter/DSPIntExtOps.cpp index ef47cc1f93..1bed755c4c 100644 --- a/Source/Core/Core/DSP/Interpreter/DSPIntExtOps.cpp +++ b/Source/Core/Core/DSP/Interpreter/DSPIntExtOps.cpp @@ -34,13 +34,10 @@ namespace Interpreter { namespace Ext { -inline bool IsSameMemArea(u16 a, u16 b) +static bool IsSameMemArea(u16 a, u16 b) { // LM: tested on Wii - if ((a >> 10) == (b >> 10)) - return true; - else - return false; + return (a >> 10) == (b >> 10); } // DR $arR