From 492bb5cceee900365476a66066518bc12595de27 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Fri, 1 May 2020 13:16:38 +0200 Subject: [PATCH 1/2] DolphinQt: Add some i18n comments for recently added strings --- Source/Core/DolphinQt/Debugger/NetworkWidget.cpp | 2 ++ Source/Core/DolphinQt/GCMemcardCreateNewDialog.cpp | 4 ++++ Source/Core/DolphinQt/Settings/AdvancedPane.cpp | 4 ++++ 3 files changed, 10 insertions(+) diff --git a/Source/Core/DolphinQt/Debugger/NetworkWidget.cpp b/Source/Core/DolphinQt/Debugger/NetworkWidget.cpp index 8adee91ca2..e05d617f11 100644 --- a/Source/Core/DolphinQt/Debugger/NetworkWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/NetworkWidget.cpp @@ -241,6 +241,7 @@ QGroupBox* NetworkWidget::CreateSocketTableGroup() socket_table_group->setLayout(socket_table_layout); m_socket_table = new QTableWidget(); + // i18n: FD stands for file descriptor (and in this case refers to sockets, not regular files) QStringList header{tr("FD"), tr("Domain"), tr("Type"), tr("State"), tr("Name")}; m_socket_table->setColumnCount(header.size()); @@ -286,6 +287,7 @@ QGroupBox* NetworkWidget::CreateSSLOptionsGroup() m_dump_ssl_read_checkbox = new QCheckBox(tr("Dump SSL read")); m_dump_ssl_write_checkbox = new QCheckBox(tr("Dump SSL write")); + // i18n: CA stands for certificate authority m_dump_root_ca_checkbox = new QCheckBox(tr("Dump root CA")); m_dump_peer_cert_checkbox = new QCheckBox(tr("Dump peer certificates")); m_verify_certificates_checkbox = new QCheckBox(tr("Verify certificates")); diff --git a/Source/Core/DolphinQt/GCMemcardCreateNewDialog.cpp b/Source/Core/DolphinQt/GCMemcardCreateNewDialog.cpp index cbd77ee32a..a7041c4dd5 100644 --- a/Source/Core/DolphinQt/GCMemcardCreateNewDialog.cpp +++ b/Source/Core/DolphinQt/GCMemcardCreateNewDialog.cpp @@ -29,10 +29,14 @@ GCMemcardCreateNewDialog::GCMemcardCreateNewDialog(QWidget* parent) : QDialog(pa m_combobox_size->setCurrentIndex(5); m_radio_western = new QRadioButton(tr("Western (Windows-1252)")); + // i18n: The translation of this string should be consistent with the translation of the + // string "Western (Windows-1252)". Because of this, you may want to parse "Japanese" as + // "a character encoding which is from Japan / used in Japan" rather than "the Japanese language". m_radio_shiftjis = new QRadioButton(tr("Japanese (Shift-JIS)")); m_radio_western->setChecked(true); auto* card_size_label = new QLabel(tr("Card Size")); + // i18n: Character encoding auto* card_encoding_label = new QLabel(tr("Encoding")); auto* button_box = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel, this); button_box->button(QDialogButtonBox::Ok)->setText(tr("Create...")); diff --git a/Source/Core/DolphinQt/Settings/AdvancedPane.cpp b/Source/Core/DolphinQt/Settings/AdvancedPane.cpp index 191684ec71..3b5e8e7e5c 100644 --- a/Source/Core/DolphinQt/Settings/AdvancedPane.cpp +++ b/Source/Core/DolphinQt/Settings/AdvancedPane.cpp @@ -127,6 +127,10 @@ void AdvancedPane::CreateLayout() mem2_override_slider_layout->addWidget(m_mem2_override_slider_label); auto* ram_override_description = + // i18n: "Retail titles should be optimized for the retail memory limitations" is a + // description of how GameCube/Wii games typically behave (in other words, "Retail titles are + // normally optimized for the retail memory limitations"), not an instruction that the user + // should do something. new QLabel(tr("Adjusts the emulated sizes of MEM1 and MEM2.\n\n" "Some titles may recognize the larger memory arena(s) and take " "advantage of it, though retail titles should be optimized for " From 423241b8a2a239d69494d3711990644dd761b909 Mon Sep 17 00:00:00 2001 From: JosJuice Date: Fri, 1 May 2020 14:11:08 +0200 Subject: [PATCH 2/2] DolphinQt: Reword memory override description --- Source/Core/DolphinQt/Settings/AdvancedPane.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Source/Core/DolphinQt/Settings/AdvancedPane.cpp b/Source/Core/DolphinQt/Settings/AdvancedPane.cpp index 3b5e8e7e5c..1fccd765ae 100644 --- a/Source/Core/DolphinQt/Settings/AdvancedPane.cpp +++ b/Source/Core/DolphinQt/Settings/AdvancedPane.cpp @@ -127,13 +127,9 @@ void AdvancedPane::CreateLayout() mem2_override_slider_layout->addWidget(m_mem2_override_slider_label); auto* ram_override_description = - // i18n: "Retail titles should be optimized for the retail memory limitations" is a - // description of how GameCube/Wii games typically behave (in other words, "Retail titles are - // normally optimized for the retail memory limitations"), not an instruction that the user - // should do something. new QLabel(tr("Adjusts the emulated sizes of MEM1 and MEM2.\n\n" "Some titles may recognize the larger memory arena(s) and take " - "advantage of it, though retail titles should be optimized for " + "advantage of it, though retail titles are normally optimized for " "the retail memory limitations.")); ram_override_description->setWordWrap(true); ram_override_layout->addWidget(ram_override_description);