Clang 3.4 exposes some warnings on Android.

Fixes all warnings on Android build except for what is in externals.
Removes a function from TextureDecoder_Generic since it is unused and generates a warning.
This commit is contained in:
Ryan Houdek
2014-03-17 18:17:12 -05:00
parent 8f0fa997cb
commit 484fb46390
7 changed files with 12 additions and 27 deletions

View File

@ -27,7 +27,7 @@ void cInterfaceGLX::SwapInterval(int Interval)
else
ERROR_LOG(VIDEO, "No support for SwapInterval (framerate clamped to monitor refresh rate).");
}
void* cInterfaceGLX::GetFuncAddress(std::string name)
void* cInterfaceGLX::GetFuncAddress(const std::string& name)
{
return (void*)glXGetProcAddress((const GLubyte*)name.c_str());
}

View File

@ -18,7 +18,7 @@ public:
void SwapInterval(int Interval) override;
void Swap() override;
void UpdateFPSDisplay(const std::string& text) override;
void* GetFuncAddress(std::string name) override;
void* GetFuncAddress(const std::string& name) override;
bool Create(void *&window_handle) override;
bool MakeCurrent() override;
bool ClearCurrent() override;

View File

@ -28,7 +28,7 @@ public:
virtual void UpdateFPSDisplay(const std::string& text) {}
virtual void SetMode(u32 mode) { s_opengl_mode = GLInterfaceMode::MODE_OPENGL; }
virtual u32 GetMode() { return s_opengl_mode; }
virtual void* GetFuncAddress(std::string name) { return nullptr; }
virtual void* GetFuncAddress(const std::string& name) { return nullptr; }
virtual bool Create(void *&window_handle) { return true; }
virtual bool MakeCurrent() { return true; }
virtual bool ClearCurrent() { return true; }

View File

@ -33,7 +33,7 @@ void cInterfaceWGL::Swap()
SwapBuffers(hDC);
}
void* cInterfaceWGL::GetFuncAddress(std::string name)
void* cInterfaceWGL::GetFuncAddress(const std::string& name)
{
void* func = (void*)wglGetProcAddress((LPCSTR)name.c_str());
if (func == nullptr)

View File

@ -13,7 +13,7 @@ public:
void SwapInterval(int Interval);
void Swap();
void UpdateFPSDisplay(const std::string& text);
void* GetFuncAddress(std::string name);
void* GetFuncAddress(const std::string& name);
bool Create(void *&window_handle);
bool MakeCurrent();
bool ClearCurrent();