From 381c2702f633e7413258bca2637b4301e231542e Mon Sep 17 00:00:00 2001 From: Tillmann Karras Date: Mon, 1 Jan 2024 21:45:28 +0000 Subject: [PATCH] DSPHLE/Zelda: fix reverb volume being multiplied by current volume twice --- Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp b/Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp index c6d2fdb907..80b7ac72b9 100644 --- a/Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp +++ b/Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp @@ -1217,11 +1217,9 @@ void ZeldaAudioRenderer::AddVoice(u16 voice_id) // Compute reverb volume and ramp deltas. s16 reverb_volumes[4], reverb_volume_deltas[4]; - s16 reverb_volume_factor = - (vpb.dolby_volume_current * vpb.dolby_reverb_factor) >> (shift_factor - 1); for (size_t i = 0; i < 4; ++i) { - reverb_volumes[i] = (quadrant_volumes[i] * reverb_volume_factor) >> shift_factor; + reverb_volumes[i] = (quadrant_volumes[i] * vpb.dolby_reverb_factor) >> shift_factor; reverb_volume_deltas[i] = (volume_deltas[i] * vpb.dolby_reverb_factor) >> shift_factor; }