piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-25 15:19:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

CodeDiffDialog: Pass QString by const reference to create_item

Browse Source 
Avoids churning string copies when updating
This commit is contained in:
Lioncash
2023-06-08 11:48:06 -04:00
parent c99b0f2eb8
commit 496aea54c0
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/DolphinQt/Debugger/CodeDiffDialog.cpp
View File

@ -361,7 +361,7 @@ void CodeDiffDialog::Update(bool include)
OnExclude(); OnExclude();
} }
const auto create_item = [](const QString string = {}, const u32 address = 0x00000000) { const auto create_item = [](const QString& string = {}, const u32 address = 0x00000000) {
QTableWidgetItem* item = new QTableWidgetItem(string); QTableWidgetItem* item = new QTableWidgetItem(string);
item->setData(Qt::UserRole, address); item->setData(Qt::UserRole, address);
item->setFlags(Qt::ItemIsEnabled | Qt::ItemIsSelectable); item->setFlags(Qt::ItemIsEnabled | Qt::ItemIsSelectable);