piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2024-11-14 21:37:52 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Qt/AchievementHeaderWidget: Don't crash when we get an empty player or game badge

Browse Source
This commit is contained in:
Admiral H. Curtiss 2024-07-15 21:47:59 +02:00
parent d665175a2b
commit 50b318cc31
No known key found for this signature in database
GPG Key ID: F051B4C4044F33FB
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Source/Core/DolphinQt/Achievements/AchievementHeaderWidget.cpp
View File

@ -84,10 +84,13 @@ void AchievementHeaderWidget::UpdateData()
m_user_icon->setVisible(false); m_user_icon->setVisible(false);
m_user_icon->clear(); m_user_icon->clear();
m_user_icon->setText({}); m_user_icon->setText({});
QImage i_user_icon(&player_badge.data.front(), player_badge.width, player_badge.height, if (!player_badge.data.empty())
{
QImage i_user_icon(player_badge.data.data(), player_badge.width, player_badge.height,
QImage::Format_RGBA8888); QImage::Format_RGBA8888);
m_user_icon->setPixmap(QPixmap::fromImage(i_user_icon) m_user_icon->setPixmap(QPixmap::fromImage(i_user_icon)
.scaled(64, 64, Qt::KeepAspectRatio, Qt::SmoothTransformation)); .scaled(64, 64, Qt::KeepAspectRatio, Qt::SmoothTransformation));
}
m_user_icon->adjustSize(); m_user_icon->adjustSize();
m_user_icon->setStyleSheet(QStringLiteral("border: 4px solid transparent")); m_user_icon->setStyleSheet(QStringLiteral("border: 4px solid transparent"));
m_user_icon->setVisible(true); m_user_icon->setVisible(true);
@ -100,10 +103,13 @@ void AchievementHeaderWidget::UpdateData()
{ {
rc_client_user_game_summary_t game_summary; rc_client_user_game_summary_t game_summary;
rc_client_get_user_game_summary(instance.GetClient(), &game_summary); rc_client_get_user_game_summary(instance.GetClient(), &game_summary);
QImage i_game_icon(&game_badge.data.front(), game_badge.width, game_badge.height, if (game_badge.data.empty())
{
QImage i_game_icon(game_badge.data.data(), game_badge.width, game_badge.height,
QImage::Format_RGBA8888); QImage::Format_RGBA8888);
m_game_icon->setPixmap(QPixmap::fromImage(i_game_icon) m_game_icon->setPixmap(QPixmap::fromImage(i_game_icon)
.scaled(64, 64, Qt::KeepAspectRatio, Qt::SmoothTransformation)); .scaled(64, 64, Qt::KeepAspectRatio, Qt::SmoothTransformation));
}
m_game_icon->adjustSize(); m_game_icon->adjustSize();
std::string_view color = AchievementManager::GRAY; std::string_view color = AchievementManager::GRAY;
if (game_summary.num_core_achievements == game_summary.num_unlocked_achievements) if (game_summary.num_core_achievements == game_summary.num_unlocked_achievements)