piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #13464 from jordan-woyak/dont-toggle-skip-frames

Browse Source 
DolphinQt: Don't auto toggle GFX_HACK_SKIP_DUPLICATE_XFBS.
This commit is contained in:
JMC47
2025-05-01 21:28:13 -04:00
committed by GitHub
parent 7222779e21 4533605c03
commit 539a3ed021
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
Source/Core/DolphinQt/Config/Graphics/HacksWidget.cpp
View File

@ -196,12 +196,16 @@ void HacksWidget::AddDescriptions()
static const char TR_IMMEDIATE_XFB_DESCRIPTION[] = QT_TR_NOOP( static const char TR_IMMEDIATE_XFB_DESCRIPTION[] = QT_TR_NOOP(
"Displays XFB copies as soon as they are created, instead of waiting for " "Displays XFB copies as soon as they are created, instead of waiting for "
"scanout.<br><br>Can cause graphical defects in some games if the game doesn't " "scanout.<br><br>Can cause graphical defects in some games if the game doesn't "
"expect all XFB copies to be displayed. However, turning this setting on reduces " "expect all XFB copies to be displayed. However, turning this setting on reduces latency."
"latency.<br><br><dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>"); "<br><br>Enabling this also force an effect equivalent to the"
" Skip Presenting Duplicate Frames setting."
"<br><br><dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>");
static const char TR_SKIP_DUPLICATE_XFBS_DESCRIPTION[] = QT_TR_NOOP( static const char TR_SKIP_DUPLICATE_XFBS_DESCRIPTION[] = QT_TR_NOOP(
"Skips presentation of duplicate frames (XFB copies) in 25fps/30fps games. " "Skips presentation of duplicate frames (XFB copies) in 25fps/30fps games. "
"This may improve performance on low-end devices, while making frame pacing less consistent." "This may improve performance on low-end devices, while making frame pacing less consistent."
"<br><br>Disable this option for optimal frame pacing." "<br><br>Disable this option for optimal frame pacing."
"<br><br>This setting is unavailable when Immediately Present XFB or VBI Skip is "
"enabled. In those cases, duplicate frames are never presented."
"<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>"); "<br><br><dolphin_emphasis>If unsure, leave this checked.</dolphin_emphasis>");
static const char TR_GPU_DECODING_DESCRIPTION[] = QT_TR_NOOP( static const char TR_GPU_DECODING_DESCRIPTION[] = QT_TR_NOOP(
"Enables texture decoding using the GPU instead of the CPU.<br><br>This may result in " "Enables texture decoding using the GPU instead of the CPU.<br><br>This may result in "
@ -230,6 +234,8 @@ void HacksWidget::AddDescriptions()
static const char TR_VI_SKIP_DESCRIPTION[] = static const char TR_VI_SKIP_DESCRIPTION[] =
QT_TR_NOOP("Skips Vertical Blank Interrupts when lag is detected, allowing for " QT_TR_NOOP("Skips Vertical Blank Interrupts when lag is detected, allowing for "
"smooth audio playback when emulation speed is not 100%. <br><br>" "smooth audio playback when emulation speed is not 100%. <br><br>"
"Enabling this also forces the effect of the"
" Skip Presenting Duplicate Frames setting.<br><br>"
"<dolphin_emphasis>WARNING: Can cause freezes and compatibility " "<dolphin_emphasis>WARNING: Can cause freezes and compatibility "
"issues.</dolphin_emphasis> <br><br>" "issues.</dolphin_emphasis> <br><br>"
"<dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>"); "<dolphin_emphasis>If unsure, leave this unchecked.</dolphin_emphasis>");
@ -263,12 +269,5 @@ void HacksWidget::UpdateSkipPresentingDuplicateFramesEnabled()
{ {
// If Immediate XFB is on, there's no point to skipping duplicate XFB copies as immediate presents // If Immediate XFB is on, there's no point to skipping duplicate XFB copies as immediate presents
// when the XFB is created, therefore all XFB copies will be unique. // when the XFB is created, therefore all XFB copies will be unique.
// This setting is also required for VI skip to work. m_skip_duplicate_xfbs->setDisabled(m_immediate_xfb->isChecked() || m_vi_skip->isChecked());
const bool disabled = m_immediate_xfb->isChecked() || m_vi_skip->isChecked();
if (disabled)
m_skip_duplicate_xfbs->setChecked(true);
m_skip_duplicate_xfbs->setEnabled(!disabled);
} }