piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-30 01:29:42 -06:00
Code Issues Packages Projects Releases Wiki Activity

FifoPlayer: Store early memory updates option in the config

Browse Source 
Now, early memory updates is persisted across runs, and can be toggled before starting a fifolog.
This commit is contained in:
Pokechu22
2022-01-06 14:38:09 -08:00
parent 193ca92cb8
commit 575062a612
6 changed files with 45 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/Core/FifoPlayer/FifoPlayer.cpp
View File

@ -165,10 +165,13 @@ bool IsPlayingBackFifologWithBrokenEFBCopies = false;
FifoPlayer::FifoPlayer() : m_Loop{Config::Get(Config::MAIN_FIFOPLAYER_LOOP_REPLAY)}
{
m_config_changed_callback_id = Config::AddConfigChangedCallback([this] { RefreshConfig(); });
RefreshConfig();
}
FifoPlayer::~FifoPlayer()
{
Config::RemoveConfigChangedCallback(m_config_changed_callback_id);
}
bool FifoPlayer::Open(const std::string& filename)
@ -298,6 +301,11 @@ std::unique_ptr<CPUCoreBase> FifoPlayer::GetCPUCore()
return std::make_unique<CPUCore>(this);
}
void FifoPlayer::RefreshConfig()
{
m_EarlyMemoryUpdates = Config::Get(Config::MAIN_FIFOPLAYER_EARLY_MEMORY_UPDATES);
}
void FifoPlayer::SetFileLoadedCallback(CallbackFunc callback)
{
m_FileLoadedCb = std::move(callback);

11
Source/Core/Core/FifoPlayer/FifoPlayer.h
View File

@ -122,9 +122,7 @@ public:
void SetObjectRangeStart(u32 start) { m_ObjectRangeStart = start; }
u32 GetObjectRangeEnd() const { return m_ObjectRangeEnd; }
void SetObjectRangeEnd(u32 end) { m_ObjectRangeEnd = end; }
// If enabled then all memory updates happen at once before the first frame
// Default is disabled
void SetEarlyMemoryUpdates(bool enabled) { m_EarlyMemoryUpdates = enabled; }
// Callbacks
void SetFileLoadedCallback(CallbackFunc callback);
void SetFrameWrittenCallback(CallbackFunc callback) { m_FrameWrittenCb = std::move(callback); }
@ -172,7 +170,11 @@ private:
static bool IsIdleSet();
static bool IsHighWatermarkSet();
void RefreshConfig();
bool m_Loop;
// If enabled then all memory updates happen at once before the first frame
bool m_EarlyMemoryUpdates = false;
u32 m_CurrentFrame = 0;
u32 m_FrameRangeStart = 0;
@ -181,14 +183,13 @@ private:
u32 m_ObjectRangeStart = 0;
u32 m_ObjectRangeEnd = 10000;
bool m_EarlyMemoryUpdates = false;
u64 m_CyclesPerFrame = 0;
u32 m_ElapsedCycles = 0;
u32 m_FrameFifoSize = 0;
CallbackFunc m_FileLoadedCb = nullptr;
CallbackFunc m_FrameWrittenCb = nullptr;
size_t m_config_changed_callback_id;
std::unique_ptr<FifoDataFile> m_File;