piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

DolphinQt: Replace widespread SetQWidgetWindowDecorations calls with an event filter.

Browse Source
This commit is contained in:
Jordan Woyak
2025-05-16 12:55:37 -05:00
parent 52fcdde485
commit 5906512847
47 changed files with 77 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
Source/Core/DolphinQt/QtUtils/SetWindowDecorations.cpp
View File

@ -1,25 +1,81 @@
// Copyright 2023 Dolphin Emulator Project
// SPDX-License-Identifier: GPL-2.0-or-later
#if defined(_WIN32)
#include "DolphinQt/QtUtils/SetWindowDecorations.h"
#include <QApplication>
#include <QEvent>
#include <QWidget>
#include <dwmapi.h>
#include "DolphinQt/Settings.h"
#ifdef _WIN32
#include <dwmapi.h>
#endif
namespace
{
void SetQWidgetWindowDecorations(QWidget* widget)
{
#ifdef _WIN32
if (!Settings::Instance().IsThemeDark())
return;
BOOL use_dark_title_bar = TRUE;
DwmSetWindowAttribute(HWND(widget->winId()),
20 /* DWMWINDOWATTRIBUTE::DWMWA_USE_IMMERSIVE_DARK_MODE */,
&use_dark_title_bar, DWORD(sizeof(use_dark_title_bar)));
#endif
constexpr DWORD attribute = 20; // DWMWINDOWATTRIBUTE::DWMWA_USE_IMMERSIVE_DARK_MODE
constexpr BOOL use_dark_title_bar = TRUE;
DwmSetWindowAttribute(HWND(widget->winId()), attribute, &use_dark_title_bar,
DWORD(sizeof(use_dark_title_bar)));
}
class WindowDecorationFilter final : public QObject
{
public:
using QObject::QObject;
bool eventFilter(QObject* obj, QEvent* event) override
{
if (event->type() == QEvent::Show || event->type() == QEvent::ApplicationPaletteChange)
{
SetQWidgetWindowDecorations(static_cast<QWidget*>(obj));
}
return QObject::eventFilter(obj, event);
}
};
class WindowDecorationFilterInstaller final : public QObject
{
public:
using QObject::QObject;
bool eventFilter(QObject* obj, QEvent* event) override
{
if (event->type() == QEvent::WinIdChange)
{
auto* const widget = qobject_cast<QWidget*>(obj);
// Install the real filter on actual Window QWidgets.
// This avoids the need for a qobject_cast on literally every QEvent::Show.
if (widget && widget->isWindow())
widget->installEventFilter(m_decoration_filter);
}
return QObject::eventFilter(obj, event);
}
private:
QObject* const m_decoration_filter = new WindowDecorationFilter{this};
};
} // namespace
namespace QtUtils
{
void InstallWindowDecorationFilter(QApplication* app)
{
app->installEventFilter(new WindowDecorationFilterInstaller{app});
}
} // namespace QtUtils
#endif