Common: Use fmt where applicable

Begins the transition to using fmt for string formatting where
applicable. Given fmt supports formatting std::string instances out of
the box, we can remove now-unnecessary calls to .c_str() and .data().

Note that this change does not touch the actual logging subsystem aside
from converting the final StringFromFormat call in the process over to
fmt::format. Given our logging system is heavily used throughout the
entire codebase, and converting that over will be quite a large change
by itself, this will be tackled near the end of the conversion process.
This commit is contained in:
Lioncash
2019-06-14 10:53:46 -04:00
parent 925afcae3b
commit 5b92d5076a
13 changed files with 287 additions and 263 deletions

View File

@ -2,12 +2,15 @@
// Licensed under GPLv2+
// Refer to the license.txt file included.
#include "Common/MD5.h"
#include <fstream>
#include <functional>
#include <mbedtls/md5.h>
#include <string>
#include "Common/MD5.h"
#include <fmt/format.h>
#include "Common/StringUtil.h"
#include "DiscIO/Blob.h"
@ -45,7 +48,7 @@ std::string MD5Sum(const std::string& file_path, std::function<bool(int)> report
// Convert to hex
for (u8 n : output)
output_string += StringFromFormat("%02x", n);
output_string += fmt::format("{:02x}", n);
return output_string;
}