piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-06-28 01:49:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

InputCommon/SDL: Avoid potential infinite loops from integer truncation.

Browse Source
This commit is contained in:
Admiral H. Curtiss
2024-01-15 15:19:24 +01:00
parent d657ad5932
commit 5e6e61c723
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/InputCommon/ControllerInterface/SDL/SDL.cpp
View File

@ -453,11 +453,11 @@ GameController::GameController(SDL_GameController* const gamecontroller,
// Legacy inputs
// Buttons
for (u8 i = 0; i != n_legacy_buttons; ++i)
for (int i = 0; i != n_legacy_buttons; ++i)
AddInput(new LegacyButton(m_joystick, i, !is_button_mapped[i]));
// Axes
for (u8 i = 0; i != n_legacy_axes; ++i)
for (int i = 0; i != n_legacy_axes; ++i)
{
// each axis gets a negative and a positive input instance associated with it
AddAnalogInputs(new LegacyAxis(m_joystick, i, -32768, !is_axis_mapped[i]),
@ -465,7 +465,7 @@ GameController::GameController(SDL_GameController* const gamecontroller,
}
// Hats
for (u8 i = 0; i != n_legacy_hats; ++i)
for (int i = 0; i != n_legacy_hats; ++i)
{
// each hat gets 4 input instances associated with it, (up down left right)
for (u8 d = 0; d != 4; ++d)