Apply suggestions from code review

Co-authored-by: Mai <mathew1800@gmail.com>
Co-authored-by: BhaaL <bhaalsen@gmail.com>
Co-authored-by: iwubcode <iwubcode@users.noreply.github.com>
This commit is contained in:
Scott Mansell
2023-02-03 13:18:37 +13:00
parent e0a1631659
commit 60f2b5af7b
18 changed files with 44 additions and 31 deletions

View File

@ -16,7 +16,7 @@ class SwapChain;
class DXTexture;
class DXFramebuffer;
class Gfx : public ::AbstractGfx
class Gfx final : public ::AbstractGfx
{
public:
Gfx(std::unique_ptr<SwapChain> swap_chain, float backbuffer_scale);

View File

@ -69,7 +69,6 @@ public:
void BindBackbuffer(const ClearColor& clear_color = {}) override;
void PresentBackbuffer() override;
// Returns info about the main surface (aka backbuffer)
SurfaceInfo GetSurfaceInfo() const override;
private:

View File

@ -19,7 +19,7 @@ class VKFramebuffer;
class VKPipeline;
class VKTexture;
class VKGfx : public ::AbstractGfx
class VKGfx final : public ::AbstractGfx
{
public:
VKGfx(std::unique_ptr<SwapChain> swap_chain, float backbuffer_scale);
@ -77,7 +77,6 @@ public:
void SetFullscreen(bool enable_fullscreen) override;
bool IsFullscreen() const override;
// Returns info about the main surface (aka backbuffer)
virtual SurfaceInfo GetSurfaceInfo() const override;
// Completes the current render pass, executes the command buffer, and restores state ready for