Merge pull request #13522 from tygyh/Enforce-overriding-destructor-style-Core&UnitTests

Core & UnitTests: Make overriding explicit and remove redundant virtual specifiers on overriding destructors

Source/Core/DolphinQt/CheatsManager.h

@@ -34,7 +34,7 @@ class CheatsManager : public QDialog
   Q_OBJECT
 public:
   explicit CheatsManager(Core::System& system, QWidget* parent = nullptr);
-  ~CheatsManager();
+  ~CheatsManager() override;
 
 signals:
   void OpenGeneralSettings();

Source/Core/DolphinQt/Config/GameConfigHighlighter.h

@@ -17,7 +17,7 @@ class GameConfigHighlighter : public QSyntaxHighlighter
 
 public:
   explicit GameConfigHighlighter(QTextDocument* parent = nullptr);
-  ~GameConfigHighlighter();
+  ~GameConfigHighlighter() override;
 
 protected:
   void highlightBlock(const QString& text) override;

Source/Core/DolphinQt/Config/GameConfigWidget.h

@@ -29,7 +29,7 @@ class GameConfigWidget : public QWidget
   Q_OBJECT
 public:
   explicit GameConfigWidget(const UICommon::GameFile& game);
-  ~GameConfigWidget();
+  ~GameConfigWidget() override;
 
 private:
   void CreateWidgets();

Source/Core/DolphinQt/Config/Graphics/PostProcessingConfigWindow.h

@@ -27,7 +27,7 @@ class PostProcessingConfigWindow final : public QDialog
   Q_OBJECT
 public:
   explicit PostProcessingConfigWindow(EnhancementsWidget* parent, const std::string& shader);
-  ~PostProcessingConfigWindow();
+  ~PostProcessingConfigWindow() override;
 
 private:
   class ConfigGroup final

Source/Core/DolphinQt/Config/GraphicsModListWidget.h

@@ -35,7 +35,7 @@ class GraphicsModListWidget : public QWidget
   Q_OBJECT
 public:
   explicit GraphicsModListWidget(const UICommon::GameFile& game);
-  ~GraphicsModListWidget();
+  ~GraphicsModListWidget() override;
 
   void SaveToDisk();
 

Source/Core/DolphinQt/Config/LogConfigWidget.h

@@ -17,7 +17,7 @@ class LogConfigWidget final : public QDockWidget
   Q_OBJECT
 public:
   explicit LogConfigWidget(QWidget* parent = nullptr);
-  ~LogConfigWidget();
+  ~LogConfigWidget() override;
 
 protected:
   void closeEvent(QCloseEvent* event) override;

Source/Core/DolphinQt/Config/LogWidget.h

@@ -23,7 +23,7 @@ class LogWidget final : public QDockWidget
   Q_OBJECT
 public:
   explicit LogWidget(QWidget* parent = nullptr);
-  ~LogWidget();
+  ~LogWidget() override;
 
 protected:
   void closeEvent(QCloseEvent*) override;

Source/Core/DolphinQt/Config/Mapping/GCPadWiiUConfigDialog.h

@@ -15,7 +15,7 @@ class GCPadWiiUConfigDialog final : public QDialog
   Q_OBJECT
 public:
   explicit GCPadWiiUConfigDialog(int port, QWidget* parent = nullptr);
-  ~GCPadWiiUConfigDialog();
+  ~GCPadWiiUConfigDialog() override;
 
 private:
   void LoadSettings();

Source/Core/DolphinQt/Debugger/AssemblerWidget.h

@@ -31,10 +31,10 @@ public:
 
   bool ApplicationCloseRequest();
 
-  ~AssemblerWidget();
+  ~AssemblerWidget() override;
 
 protected:
-  void closeEvent(QCloseEvent*);
+  void closeEvent(QCloseEvent*) override;
 
 private:
   enum class AsmKind

Source/Core/DolphinQt/Debugger/BreakpointWidget.cpp

@@ -65,7 +65,8 @@ public:
   CustomDelegate(BreakpointWidget* parent) : QStyledItemDelegate(parent) {}
 
 private:
-  void paint(QPainter* painter, const QStyleOptionViewItem& option, const QModelIndex& index) const
+  void paint(QPainter* painter, const QStyleOptionViewItem& option,
+             const QModelIndex& index) const override
   {
     Q_ASSERT(index.isValid());
 

Source/Core/DolphinQt/Debugger/BreakpointWidget.h

@@ -31,7 +31,7 @@ class BreakpointWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit BreakpointWidget(QWidget* parent = nullptr);
-  ~BreakpointWidget();
+  ~BreakpointWidget() override;
 
   void AddBP(u32 addr);
   void AddBP(u32 addr, bool break_on_hit, bool log_on_hit, const QString& condition);

Source/Core/DolphinQt/Debugger/CodeWidget.h

@@ -33,7 +33,7 @@ class CodeWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit CodeWidget(QWidget* parent = nullptr);
-  ~CodeWidget();
+  ~CodeWidget() override;
 
   void Step();
   void StepOver();

Source/Core/DolphinQt/Debugger/GekkoSyntaxHighlight.cpp

@@ -16,7 +16,7 @@ using namespace Common::GekkoAssembler::detail;
 class HighlightParsePlugin : public ParsePlugin
 {
 public:
-  virtual ~HighlightParsePlugin() = default;
+  ~HighlightParsePlugin() override = default;
 
   std::vector<std::pair<int, int>>&& MoveParens() { return std::move(m_matched_parens); }
   std::vector<std::tuple<int, int, HighlightFormat>>&& MoveFormatting()

Source/Core/DolphinQt/Debugger/MemoryWidget.h

@@ -32,7 +32,7 @@ class MemoryWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit MemoryWidget(Core::System& system, QWidget* parent = nullptr);
-  ~MemoryWidget();
+  ~MemoryWidget() override;
 
   void SetAddress(u32 address);
   void Update();

Source/Core/DolphinQt/Debugger/NetworkWidget.h

@@ -21,7 +21,7 @@ class NetworkWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit NetworkWidget(QWidget* parent = nullptr);
-  ~NetworkWidget();
+  ~NetworkWidget() override;
 
 protected:
   void closeEvent(QCloseEvent*) override;

Source/Core/DolphinQt/Debugger/RegisterWidget.h

@@ -23,7 +23,7 @@ class RegisterWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit RegisterWidget(QWidget* parent = nullptr);
-  ~RegisterWidget();
+  ~RegisterWidget() override;
 
 signals:
   void RequestTableUpdate();

Source/Core/DolphinQt/Debugger/ThreadWidget.h

@@ -19,7 +19,7 @@ class ThreadWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit ThreadWidget(QWidget* parent = nullptr);
-  ~ThreadWidget();
+  ~ThreadWidget() override;
 
 signals:
   void RequestBreakpoint(u32 addr);

Source/Core/DolphinQt/Debugger/WatchWidget.h

@@ -25,7 +25,7 @@ class WatchWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit WatchWidget(QWidget* parent = nullptr);
-  ~WatchWidget();
+  ~WatchWidget() override;
 
   void AddWatch(QString name, u32 addr);
 signals:

Source/Core/DolphinQt/DiscordHandler.h

@@ -22,7 +22,7 @@ class DiscordHandler : public QObject, public Discord::Handler
 #ifdef USE_DISCORD_PRESENCE
 public:
   explicit DiscordHandler(QWidget* parent);
-  ~DiscordHandler();
+  ~DiscordHandler() override;
 
   void Start();
   void Stop();

Source/Core/DolphinQt/FIFO/FIFOAnalyzer.h

@@ -26,7 +26,7 @@ class FIFOAnalyzer final : public QWidget
 
 public:
   explicit FIFOAnalyzer(FifoPlayer& fifo_player);
-  ~FIFOAnalyzer();
+  ~FIFOAnalyzer() override;
 
   void Update();
 

Source/Core/DolphinQt/FIFO/FIFOPlayerWindow.h

@@ -23,7 +23,7 @@ class FIFOPlayerWindow : public QWidget
 public:
   explicit FIFOPlayerWindow(FifoPlayer& fifo_player, FifoRecorder& fifo_recorder,
                             QWidget* parent = nullptr);
-  ~FIFOPlayerWindow();
+  ~FIFOPlayerWindow() override;
 
 signals:
   void LoadFIFORequested(const QString& path);
@@ -50,7 +50,7 @@ private:
   void UpdateInfo();
   void UpdateLimits();
 
-  bool eventFilter(QObject* object, QEvent* event) final override;
+  bool eventFilter(QObject* object, QEvent* event) final;
 
   FifoPlayer& m_fifo_player;
   FifoRecorder& m_fifo_recorder;

Source/Core/DolphinQt/GBAHost.h

@@ -18,7 +18,7 @@ class GBAHost : public GBAHostInterface
 {
 public:
   explicit GBAHost(std::weak_ptr<HW::GBA::Core> core);
-  ~GBAHost();
+  ~GBAHost() override;
   void GameChanged() override;
   void FrameEnded(const std::vector<u32>& video_buffer) override;
 

Source/Core/DolphinQt/GCMemcardCreateNewDialog.h

@@ -13,7 +13,7 @@ class GCMemcardCreateNewDialog : public QDialog
   Q_OBJECT
 public:
   explicit GCMemcardCreateNewDialog(QWidget* parent = nullptr);
-  ~GCMemcardCreateNewDialog();
+  ~GCMemcardCreateNewDialog() override;
 
   std::string GetMemoryCardPath() const;
 

Source/Core/DolphinQt/GCMemcardManager.h

@@ -41,7 +41,7 @@ class GCMemcardManager : public QDialog
   Q_OBJECT
 public:
   explicit GCMemcardManager(QWidget* parent = nullptr);
-  ~GCMemcardManager();
+  ~GCMemcardManager() override;
 
   static QString GetErrorMessagesForErrorCode(const Memcard::GCMemcardErrorCode& code);
   static QString GetErrorMessageForErrorCode(Memcard::ReadSavefileErrorCode code);

Source/Core/DolphinQt/GameList/GameList.h

@@ -26,7 +26,7 @@ class GameList final : public QStackedWidget
 
 public:
   explicit GameList(QWidget* parent = nullptr);
-  ~GameList();
+  ~GameList() override;
 
   std::shared_ptr<const UICommon::GameFile> GetSelectedGame() const;
   QList<std::shared_ptr<const UICommon::GameFile>> GetSelectedGames() const;

Source/Core/DolphinQt/Host.h

@@ -17,7 +17,7 @@ class Host final : public QObject
   Q_OBJECT
 
 public:
-  ~Host();
+  ~Host() override;
 
   static Host* GetInstance();
 

Source/Core/DolphinQt/HotkeyScheduler.h

@@ -16,7 +16,7 @@ class HotkeyScheduler : public QObject
   Q_OBJECT
 public:
   explicit HotkeyScheduler();
-  ~HotkeyScheduler();
+  ~HotkeyScheduler() override;
 
   void Start();
   void Stop();

Source/Core/DolphinQt/MainWindow.h

@@ -85,7 +85,7 @@ class MainWindow final : public QMainWindow
 public:
   explicit MainWindow(Core::System& system, std::unique_ptr<BootParameters> boot_parameters,
                       const std::string& movie_path);
-  ~MainWindow();
+  ~MainWindow() override;
 
   WindowSystemInfo GetWindowSystemInfo() const;
 

Source/Core/DolphinQt/NetPlay/NetPlayBrowser.h

@@ -29,7 +29,7 @@ class NetPlayBrowser : public QDialog
   Q_OBJECT
 public:
   explicit NetPlayBrowser(QWidget* parent = nullptr);
-  ~NetPlayBrowser();
+  ~NetPlayBrowser() override;
 
   void accept() override;
 signals:

Source/Core/DolphinQt/NetPlay/NetPlayDialog.h

@@ -40,7 +40,7 @@ public:
 
   explicit NetPlayDialog(const GameListModel& game_list_model,
                          StartGameCallback start_game_callback, QWidget* parent = nullptr);
-  ~NetPlayDialog();
+  ~NetPlayDialog() override;
 
   void show(std::string nickname, bool use_traversal);
   void reject() override;

Source/Core/DolphinQt/QtUtils/ElidedButton.h

@@ -14,9 +14,9 @@ public:
   Qt::TextElideMode elideMode() const;
   void setElideMode(Qt::TextElideMode elide_mode);
 
-  QSize sizeHint() const final override;
+  QSize sizeHint() const final;
 
 private:
-  void paintEvent(QPaintEvent* event) final override;
+  void paintEvent(QPaintEvent* event) final;
   Qt::TextElideMode m_elide_mode;
 };

Source/Core/DolphinQt/RiivolutionBootWidget.h

@@ -24,7 +24,7 @@ public:
   explicit RiivolutionBootWidget(std::string game_id, std::optional<u16> revision,
                                  std::optional<u8> disc, std::string base_game_path,
                                  QWidget* parent = nullptr);
-  ~RiivolutionBootWidget();
+  ~RiivolutionBootWidget() override;
 
   bool ShouldBoot() const { return m_should_boot; }
   std::vector<DiscIO::Riivolution::Patch>& GetPatches() { return m_patches; }

Source/Core/DolphinQt/SearchBar.h

@@ -24,7 +24,7 @@ private:
   void CreateWidgets();
   void ConnectWidgets();
 
-  bool eventFilter(QObject* object, QEvent* event) final override;
+  bool eventFilter(QObject* object, QEvent* event) final;
 
   QLineEdit* m_search_edit;
   QPushButton* m_close_button;

Source/Core/DolphinQt/Settings.h

@@ -44,7 +44,7 @@ public:
   Settings(Settings&&) = delete;
   Settings& operator=(Settings&&) = delete;
 
-  ~Settings();
+  ~Settings() override;
 
   void UnregisterDevicesChangedCallback();
 

Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.h

@@ -56,7 +56,7 @@ private:
   QVBoxLayout* CreateSlotLayout();
   QVBoxLayout* CreateFinderLayout();
   void closeEvent(QCloseEvent* bar) override;
-  bool eventFilter(QObject* object, QEvent* event) final override;
+  bool eventFilter(QObject* object, QEvent* event) final;
 
   // UI
   void EmulatePortal(bool emulate);