Merge pull request #13522 from tygyh/Enforce-overriding-destructor-style-Core&UnitTests

Core & UnitTests: Make overriding explicit and remove redundant virtual specifiers on overriding destructors

Source/Core/DolphinQt/Debugger/AssemblerWidget.h

@@ -31,10 +31,10 @@ public:
 
   bool ApplicationCloseRequest();
 
-  ~AssemblerWidget();
+  ~AssemblerWidget() override;
 
 protected:
-  void closeEvent(QCloseEvent*);
+  void closeEvent(QCloseEvent*) override;
 
 private:
   enum class AsmKind

Source/Core/DolphinQt/Debugger/BreakpointWidget.cpp

@@ -65,7 +65,8 @@ public:
   CustomDelegate(BreakpointWidget* parent) : QStyledItemDelegate(parent) {}
 
 private:
-  void paint(QPainter* painter, const QStyleOptionViewItem& option, const QModelIndex& index) const
+  void paint(QPainter* painter, const QStyleOptionViewItem& option,
+             const QModelIndex& index) const override
   {
     Q_ASSERT(index.isValid());
 

Source/Core/DolphinQt/Debugger/BreakpointWidget.h

@@ -31,7 +31,7 @@ class BreakpointWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit BreakpointWidget(QWidget* parent = nullptr);
-  ~BreakpointWidget();
+  ~BreakpointWidget() override;
 
   void AddBP(u32 addr);
   void AddBP(u32 addr, bool break_on_hit, bool log_on_hit, const QString& condition);

Source/Core/DolphinQt/Debugger/CodeWidget.h

@@ -33,7 +33,7 @@ class CodeWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit CodeWidget(QWidget* parent = nullptr);
-  ~CodeWidget();
+  ~CodeWidget() override;
 
   void Step();
   void StepOver();

Source/Core/DolphinQt/Debugger/GekkoSyntaxHighlight.cpp

@@ -16,7 +16,7 @@ using namespace Common::GekkoAssembler::detail;
 class HighlightParsePlugin : public ParsePlugin
 {
 public:
-  virtual ~HighlightParsePlugin() = default;
+  ~HighlightParsePlugin() override = default;
 
   std::vector<std::pair<int, int>>&& MoveParens() { return std::move(m_matched_parens); }
   std::vector<std::tuple<int, int, HighlightFormat>>&& MoveFormatting()

Source/Core/DolphinQt/Debugger/MemoryWidget.h

@@ -32,7 +32,7 @@ class MemoryWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit MemoryWidget(Core::System& system, QWidget* parent = nullptr);
-  ~MemoryWidget();
+  ~MemoryWidget() override;
 
   void SetAddress(u32 address);
   void Update();

Source/Core/DolphinQt/Debugger/NetworkWidget.h

@@ -21,7 +21,7 @@ class NetworkWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit NetworkWidget(QWidget* parent = nullptr);
-  ~NetworkWidget();
+  ~NetworkWidget() override;
 
 protected:
   void closeEvent(QCloseEvent*) override;

Source/Core/DolphinQt/Debugger/RegisterWidget.h

@@ -23,7 +23,7 @@ class RegisterWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit RegisterWidget(QWidget* parent = nullptr);
-  ~RegisterWidget();
+  ~RegisterWidget() override;
 
 signals:
   void RequestTableUpdate();

Source/Core/DolphinQt/Debugger/ThreadWidget.h

@@ -19,7 +19,7 @@ class ThreadWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit ThreadWidget(QWidget* parent = nullptr);
-  ~ThreadWidget();
+  ~ThreadWidget() override;
 
 signals:
   void RequestBreakpoint(u32 addr);

Source/Core/DolphinQt/Debugger/WatchWidget.h

@@ -25,7 +25,7 @@ class WatchWidget : public QDockWidget
   Q_OBJECT
 public:
   explicit WatchWidget(QWidget* parent = nullptr);
-  ~WatchWidget();
+  ~WatchWidget() override;
 
   void AddWatch(QString name, u32 addr);
 signals: