AsyncRequests: In-class initialize class members

Prior to this change, it's possible for m_wake_me_up_again to be used
while it's in an uninitialized state from the exposed API.

e.g.

- Using SetEnable after construction would perform an uninitialized read.
- Using PushEvent would perform an uninitialized read by way of operator |=.

internally, an uninitialized read can happen if PullEventsInternal() is
executed before other functions.

Just to avoid the whole possibility of performing uninitialized reads,
we just give the class member a default value of false.
This commit is contained in:
Lioncash
2018-04-01 19:01:55 -04:00
parent bf8ffe5bfb
commit 672665dec0
2 changed files with 4 additions and 6 deletions

View File

@ -12,9 +12,7 @@
AsyncRequests AsyncRequests::s_singleton;
AsyncRequests::AsyncRequests() : m_enable(false), m_passthrough(true)
{
}
AsyncRequests::AsyncRequests() = default;
void AsyncRequests::PullEventsInternal()
{