mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-07-22 22:00:39 -06:00
AsyncRequests: In-class initialize class members
Prior to this change, it's possible for m_wake_me_up_again to be used while it's in an uninitialized state from the exposed API. e.g. - Using SetEnable after construction would perform an uninitialized read. - Using PushEvent would perform an uninitialized read by way of operator |=. internally, an uninitialized read can happen if PullEventsInternal() is executed before other functions. Just to avoid the whole possibility of performing uninitialized reads, we just give the class member a default value of false.
This commit is contained in:
@ -12,9 +12,7 @@
|
||||
|
||||
AsyncRequests AsyncRequests::s_singleton;
|
||||
|
||||
AsyncRequests::AsyncRequests() : m_enable(false), m_passthrough(true)
|
||||
{
|
||||
}
|
||||
AsyncRequests::AsyncRequests() = default;
|
||||
|
||||
void AsyncRequests::PullEventsInternal()
|
||||
{
|
||||
|
Reference in New Issue
Block a user