From 32f6d3f62bcc62f5b15a3179af05132ece5f3373 Mon Sep 17 00:00:00 2001 From: container1234 Date: Mon, 23 Apr 2018 00:46:42 +0900 Subject: [PATCH 1/3] Qt: Use HostRead for float and double --- Source/Core/DolphinQt2/CheatsManager.cpp | 12 ++++++------ Source/Core/DolphinQt2/Debugger/MemoryViewWidget.cpp | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Source/Core/DolphinQt2/CheatsManager.cpp b/Source/Core/DolphinQt2/CheatsManager.cpp index cb0956906f..ce759092ad 100644 --- a/Source/Core/DolphinQt2/CheatsManager.cpp +++ b/Source/Core/DolphinQt2/CheatsManager.cpp @@ -390,9 +390,9 @@ bool CheatsManager::MatchesSearch(u32 addr) const case DataType::Int: return Compare(PowerPC::HostRead_U32(addr), text.toUInt(nullptr, base), op); case DataType::Float: - return Compare(PowerPC::Read_F32(addr), text.toFloat(), op); + return Compare(PowerPC::HostRead_F32(addr), text.toFloat(), op); case DataType::Double: - return Compare(PowerPC::Read_F64(addr), text.toDouble(), op); + return Compare(PowerPC::HostRead_F64(addr), text.toDouble(), op); case DataType::String: { bool is_equal = std::equal(text.toUtf8().cbegin(), text.toUtf8().cend(), @@ -516,10 +516,10 @@ void CheatsManager::Update() 16, QLatin1Char('0'))); break; case DataType::Float: - value_item->setText(QString::number(PowerPC::Read_F32(m_results[i].address))); + value_item->setText(QString::number(PowerPC::HostRead_F32(m_results[i].address))); break; case DataType::Double: - value_item->setText(QString::number(PowerPC::Read_F64(m_results[i].address))); + value_item->setText(QString::number(PowerPC::HostRead_F64(m_results[i].address))); break; case DataType::String: value_item->setText(tr("String Match")); @@ -575,10 +575,10 @@ void CheatsManager::Update() 16, QLatin1Char('0'))); break; case DataType::Float: - value_item->setText(QString::number(PowerPC::Read_F32(m_watch[i].address))); + value_item->setText(QString::number(PowerPC::HostRead_F32(m_watch[i].address))); break; case DataType::Double: - value_item->setText(QString::number(PowerPC::Read_F64(m_watch[i].address))); + value_item->setText(QString::number(PowerPC::HostRead_F64(m_watch[i].address))); break; case DataType::String: value_item->setText(tr("String Match")); diff --git a/Source/Core/DolphinQt2/Debugger/MemoryViewWidget.cpp b/Source/Core/DolphinQt2/Debugger/MemoryViewWidget.cpp index 5aaa2635a6..52aff33e4f 100644 --- a/Source/Core/DolphinQt2/Debugger/MemoryViewWidget.cpp +++ b/Source/Core/DolphinQt2/Debugger/MemoryViewWidget.cpp @@ -170,7 +170,7 @@ void MemoryViewWidget::Update() }); break; case Type::Float32: - update_values([](u32 address) { return QString::number(PowerPC::Read_F32(address)); }); + update_values([](u32 address) { return QString::number(PowerPC::HostRead_F32(address)); }); break; } } From 41844c1cc5c7e64416fa911c55e65b918e5a73b5 Mon Sep 17 00:00:00 2001 From: container1234 Date: Mon, 23 Apr 2018 00:52:31 +0900 Subject: [PATCH 2/3] Qt/Debugger: Change the row height to same as code/memory widget --- Source/Core/DolphinQt2/Debugger/RegisterWidget.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Source/Core/DolphinQt2/Debugger/RegisterWidget.cpp b/Source/Core/DolphinQt2/Debugger/RegisterWidget.cpp index 9db31e3690..93720cf896 100644 --- a/Source/Core/DolphinQt2/Debugger/RegisterWidget.cpp +++ b/Source/Core/DolphinQt2/Debugger/RegisterWidget.cpp @@ -72,6 +72,7 @@ void RegisterWidget::CreateWidgets() m_table->setColumnCount(9); m_table->verticalHeader()->setVisible(false); + m_table->verticalHeader()->setDefaultSectionSize(24); m_table->setContextMenuPolicy(Qt::CustomContextMenu); m_table->setSelectionMode(QAbstractItemView::SingleSelection); From b46bf9b736d90479525597d7b173c86965332e1b Mon Sep 17 00:00:00 2001 From: container1234 Date: Mon, 23 Apr 2018 00:54:09 +0900 Subject: [PATCH 3/3] Qt/Debugger: Change CodeView background colors to bright ones --- Source/Core/DolphinQt2/Debugger/CodeViewWidget.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Core/DolphinQt2/Debugger/CodeViewWidget.cpp b/Source/Core/DolphinQt2/Debugger/CodeViewWidget.cpp index b04766f814..152a8b9273 100644 --- a/Source/Core/DolphinQt2/Debugger/CodeViewWidget.cpp +++ b/Source/Core/DolphinQt2/Debugger/CodeViewWidget.cpp @@ -143,11 +143,11 @@ void CodeViewWidget::Update() item->setData(Qt::UserRole, addr); if (color != 0xFFFFFF) - item->setBackground(QColor(color).darker(200)); + item->setBackground(QColor(color).darker(110)); if (addr == pc && item != bp_item) { - item->setBackground(Qt::darkGreen); + item->setBackground(QColor(Qt::green).darker(110)); } }