Make DolphinAnalytics a true singleton - static local variables are initialized in a thread safe manner since C++11

Also works around a Visual Studio 2017 bug where static inline class fields are destructed multiple times
This commit is contained in:
Silent
2019-06-23 19:26:07 +02:00
parent 5262f39026
commit 6c21811090
11 changed files with 16 additions and 25 deletions

View File

@ -177,7 +177,7 @@ int main(int argc, char* argv[])
int retval;
{
DolphinAnalytics::Instance()->ReportDolphinStart("qt");
DolphinAnalytics::Instance().ReportDolphinStart("qt");
MainWindow win{std::move(boot), static_cast<const char*>(options.get("movie"))};
if (options.is_set("debugger"))
@ -210,7 +210,7 @@ int main(int argc, char* argv[])
SConfig::GetInstance().m_analytics_permission_asked = true;
Settings::Instance().SetAnalyticsEnabled(answer == QMessageBox::Yes);
DolphinAnalytics::Instance()->ReloadConfig();
DolphinAnalytics::Instance().ReloadConfig();
}
#endif