piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-28 16:49:58 -06:00
Code Issues Packages Projects Releases Wiki Activity

SSE-optimize UninitializeXFBMemory

Browse Source 
Lowest hanging fruit I could find with a profiler.

Not sure this stuff actually needs to be done, but assuming it is, why
not do it quickly? 10x faster, goes from 1% CPU to 0.09%.
This commit is contained in:
Henrik Rydgård
2018-03-12 23:41:33 +01:00
parent 90ca62e416
commit 6cbb716f60
1 changed files with 30 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
Source/Core/VideoCommon/TextureCacheBase.cpp
View File

@ -8,6 +8,9 @@
#include <memory> #include <memory>
#include <string> #include <string>
#include <utility> #include <utility>
#if defined(_M_X86) || defined(_M_X86_64)
#include <pmmintrin.h>
#endif
#include "Common/Align.h" #include "Common/Align.h"
#include "Common/Assert.h" #include "Common/Assert.h"
@ -1783,24 +1786,40 @@ void TextureCacheBase::CopyRenderTargetToTexture(u32 dstAddr, EFBCopyFormat dstF
void TextureCacheBase::UninitializeXFBMemory(u8* dst, u32 stride, u32 bytes_per_row, void TextureCacheBase::UninitializeXFBMemory(u8* dst, u32 stride, u32 bytes_per_row,
u32 num_blocks_y) u32 num_blocks_y)
{ {
// Originally, we planned on using a 'key color' // Originally, we planned on using a 'key color'
// for alpha to address partial xfbs (Mario Strikers / Chicken Little). // for alpha to address partial xfbs (Mario Strikers / Chicken Little).
// This work was removed since it was unfinished but there // This work was removed since it was unfinished but there
// was still a desire to differentiate between the old and the new approach // was still a desire to differentiate between the old and the new approach
// which is why we still set uninitialized xfb memory to fuchsia // which is why we still set uninitialized xfb memory to fuchsia
// (Y=1,U=254,V=254) instead of dark green (Y=0,U=0,V=0) in YUV // (Y=1,U=254,V=254) instead of dark green (Y=0,U=0,V=0) in YUV
// like is done in the EFB path. // like is done in the EFB path.
// This comment is indented wrong because of the silly linter, btw.
#if defined(_M_X86) || defined(_M_X86_64)
__m128i sixteenBytes = _mm_set1_epi16((s16)(u16)0xFE01);
#endif
for (u32 i = 0; i < num_blocks_y; i++) for (u32 i = 0; i < num_blocks_y; i++)
{ {
for (u32 offset = 0; offset < bytes_per_row; offset++) u32 size = bytes_per_row;
u8* rowdst = dst;
#if defined(_M_X86) || defined(_M_X86_64)
while (size >= 16)
{ {
if (offset % 2) _mm_storeu_si128((__m128i*)rowdst, sixteenBytes);
size -= 16;
rowdst += 16;
}
#endif
for (u32 offset = 0; offset < size; offset++)
{
if (offset & 1)
{ {
dst[offset] = 254; rowdst[offset] = 254;
} }
else else
{ {
dst[offset] = 1; rowdst[offset] = 1;
} }
} }
dst += stride; dst += stride;