piwalker/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-07-21 05:09:34 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix invalid pointer errors in Burnout 2.

Browse Source 
Yet another story of games loading weird shit into registers.

For some reason, Burnout 2 would (in rare situations) load invalid
addresses into cp_state.array_bases. What would the real hardware
do in this situation? Who knows, Burnout 2 doesn't actually enable
the vertex array with the invalid address so nothing kinky happens.

But dolphin tries to optimise things and starts using the address
as soon as it is loaded into memory. This causes GetPointer (which is
now much more vocal) to throw an error.

The Fix:  We don't call GetPointer until we are sure the vertex array
has been enabled.
This commit is contained in:
Scott Mansell
2015-05-29 18:25:19 +12:00
parent 68d6f07b5c
commit 6d916762fb
4 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Source/Core/VideoCommon/MainBase.cpp
View File

@ -212,7 +212,6 @@ void VideoBackendHardware::DoState(PointerWrap& p)
if (p.GetMode() == PointerWrap::MODE_READ)
{
m_invalid = true;
RecomputeCachedArraybases();
// Clear all caches that touch RAM
// (? these don't appear to touch any emulation state that gets saved. moved to on load only.)