diff --git a/Source/Core/Core/Boot/Boot.h b/Source/Core/Core/Boot/Boot.h index a178edaf75..1f52daa1c5 100644 --- a/Source/Core/Core/Boot/Boot.h +++ b/Source/Core/Core/Boot/Boot.h @@ -109,8 +109,8 @@ private: class BootExecutableReader { public: - BootExecutableReader(const std::string& file_name); - BootExecutableReader(const std::vector& buffer); + explicit BootExecutableReader(const std::string& file_name); + explicit BootExecutableReader(const std::vector& buffer); virtual ~BootExecutableReader(); virtual u32 GetEntryPoint() const = 0; diff --git a/Source/Core/Core/Boot/DolReader.h b/Source/Core/Core/Boot/DolReader.h index 43b1c0f354..e2daa04733 100644 --- a/Source/Core/Core/Boot/DolReader.h +++ b/Source/Core/Core/Boot/DolReader.h @@ -13,8 +13,8 @@ class DolReader final : public BootExecutableReader { public: - DolReader(const std::string& filename); - DolReader(const std::vector& buffer); + explicit DolReader(const std::string& filename); + explicit DolReader(const std::vector& buffer); ~DolReader(); bool IsValid() const override { return m_is_valid; } diff --git a/Source/Core/Core/Boot/ElfReader.cpp b/Source/Core/Core/Boot/ElfReader.cpp index 4f9297b06d..78a77954ed 100644 --- a/Source/Core/Core/Boot/ElfReader.cpp +++ b/Source/Core/Core/Boot/ElfReader.cpp @@ -76,6 +76,8 @@ ElfReader::ElfReader(const std::string& filename) : BootExecutableReader(filenam Initialize(m_bytes.data()); } +ElfReader::~ElfReader() = default; + void ElfReader::Initialize(u8* ptr) { base = (char*)ptr; diff --git a/Source/Core/Core/Boot/ElfReader.h b/Source/Core/Core/Boot/ElfReader.h index 014d0667c3..951f5a7b57 100644 --- a/Source/Core/Core/Boot/ElfReader.h +++ b/Source/Core/Core/Boot/ElfReader.h @@ -21,9 +21,9 @@ typedef int SectionID; class ElfReader final : public BootExecutableReader { public: - ElfReader(const std::string& filename); - ElfReader(const std::vector& buffer); - ~ElfReader() {} + explicit ElfReader(const std::string& filename); + explicit ElfReader(const std::vector& buffer); + ~ElfReader(); u32 Read32(int off) const { return base32[off >> 2]; } // Quick accessors ElfType GetType() const { return (ElfType)(header->e_type); }